Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft Phrase and Cosigning #136

Merged
merged 6 commits into from
Jul 6, 2022
Merged

Draft Phrase and Cosigning #136

merged 6 commits into from
Jul 6, 2022

Conversation

chfanghr
Copy link
Contributor

Will close #96

@chfanghr chfanghr marked this pull request as draft June 28, 2022 14:44
@chfanghr chfanghr changed the base branch from connor/enum-opt to staging June 29, 2022 05:55
@chfanghr chfanghr force-pushed the connor/draft-phrase branch 2 times, most recently from 8f9fe02 to 94582ed Compare June 29, 2022 10:20
@chfanghr chfanghr changed the base branch from staging to connor/improve-script-size June 29, 2022 10:21
@chfanghr chfanghr force-pushed the connor/improve-script-size branch from 7bee90b to 6d27bf0 Compare June 29, 2022 11:14
@chfanghr chfanghr force-pushed the connor/draft-phrase branch from 94582ed to f33ebf2 Compare June 29, 2022 11:25
@chfanghr chfanghr changed the base branch from connor/improve-script-size to staging June 29, 2022 11:26
@chfanghr chfanghr force-pushed the connor/draft-phrase branch 4 times, most recently from 53fae6f to 205270f Compare June 29, 2022 11:48
@chfanghr chfanghr marked this pull request as ready for review June 29, 2022 15:12
@chfanghr chfanghr requested a review from emiflake June 29, 2022 15:12
@chfanghr chfanghr force-pushed the connor/draft-phrase branch from 871651b to e670007 Compare June 29, 2022 15:21
emiflake
emiflake requested changes Jun 30, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some things on design.

@chfanghr chfanghr force-pushed the connor/draft-phrase branch from e670007 to 46ac17c Compare July 1, 2022 05:42
@chfanghr chfanghr marked this pull request as draft July 1, 2022 05:43
@chfanghr chfanghr force-pushed the connor/draft-phrase branch from 46ac17c to b772c6b Compare July 1, 2022 09:04
@chfanghr chfanghr force-pushed the connor/draft-phrase branch 9 times, most recently from 1992a53 to f9d5866 Compare July 4, 2022 16:55
@chfanghr chfanghr force-pushed the connor/draft-phrase branch 5 times, most recently from 5695e23 to 4c376ad Compare July 4, 2022 22:26
@chfanghr chfanghr force-pushed the connor/draft-phrase branch from 4c376ad to 6c85d02 Compare July 4, 2022 23:56
@chfanghr chfanghr marked this pull request as ready for review July 4, 2022 23:57
@chfanghr chfanghr force-pushed the connor/draft-phrase branch 3 times, most recently from 8243d75 to 191d899 Compare July 5, 2022 08:45
@chfanghr chfanghr force-pushed the connor/draft-phrase branch from 191d899 to 9c8d04d Compare July 5, 2022 08:59
emiflake
emiflake requested changes Jul 6, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes.

@chfanghr chfanghr merged commit 79563c8 into staging Jul 6, 2022
@chfanghr chfanghr deleted the connor/draft-phrase branch July 7, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiflake emiflake emiflake approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Workflow: Cosignatures & draft phase
2 participants
@chfanghr @emiflake