Fix proposal creation #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfanghr
force-pushed
the
connor/fix-proposal-creation
branch
5 times, most recently
from
e168c88 to
02b87bb
Compare
chfanghr
force-pushed
the
connor/fix-proposal-creation
branch
from
a15878a to
2ffec56
Compare
chfanghr
force-pushed
the
connor/fix-proposal-creation
branch
3 times, most recently
from
4e9abef to
014fb3f
Compare
chfanghr
force-pushed
the
connor/fix-proposal-creation
branch
4 times, most recently
from
d9dcc7a to
6a3b5b2
Compare
chfanghr
force-pushed
the
connor/fix-proposal-creation
branch
3 times, most recently
from
448275a to
7b2028d
Compare
chfanghr
force-pushed
the
connor/fix-proposal-creation
branch
from
7b2028d to
6626d6c
Compare
chfanghr
force-pushed
the
connor/fix-proposal-creation
branch
from
7b4bd2d to
4b3003f
Compare
emiflake
requested changes
Jul 12, 2022
* Comment on `validateOutputLocks` * Assertion message rewording * Some comment rewording * Fix Typos * Correct `PShow` instances, derive as much we can * Remove redundant checks
chfanghr
force-pushed
the
connor/fix-proposal-creation
branch
from
ae3a10a to
77894c0
Compare
so that ps-bridge works correctly
chfanghr
force-pushed
the
connor/fix-proposal-creation
branch
from
13dbbfb to
a54a809
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close #137 and #68.
TODOs