-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use liqwid-nix
; Bump plutarch
#150
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deriving parts looks so much cleaner. Well done. |
11a1ebd
to
ebe0c55
Compare
SeungheonOh
reviewed
Aug 2, 2022
SeungheonOh
reviewed
Aug 2, 2022
f044745
to
658b46d
Compare
71ebf22
to
fdfc329
Compare
L-as
reviewed
Aug 8, 2022
4d7ee30
to
53bfffc
Compare
c536b18
to
6ca2ec1
Compare
7bc3e1a
to
219b676
Compare
emiflake
reviewed
Aug 11, 2022
emiflake
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to merge as is, if/when CI works.
95aced2
to
4a3e93b
Compare
add extra command line tool `hasktags`
4a3e93b
to
38ffa42
Compare
38ffa42
to
47d9e69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr bumps plutarch to version 1.2 and refactors the nix setup with
liqwid-nix
.Some caveats regrading the new version of plutarch:
PDataFields
for a newtype ofPDataRecord
, which derives itsPlutusType
instance usingPlutusTypeNewtype
strategy. Workaround:pto
beforepletField
.PTryfrom PData
instances forPAsData _
/PUnit
/PDatumHash
. Workaround: implemented orphan instances inAgora.Plutarch.Orphans
. Great thanks to @emiflake for debugging a plutarch compile time infinite recursion bug related to this!development
flag which controled whether to include tracing message in the compiled scripts or not has been replaced byConfig
. This dramatically changes the way we parameterize the scripts, especially when they have dependent relationship.