Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthCheck token name instead of effect validator #161

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

emiflake
Copy link
Member

Summary:

  • AuthCheck script (as encoded in proposal effect group) is used for token name instead of effect script.

This change breaks compatibility with scripts using an older authority token check, but future scripts will be compatible between those who do check for AuthCheck scripts and those who don't.

@emiflake emiflake requested a review from chfanghr August 23, 2022 10:36
Copy link
Contributor

@chfanghr chfanghr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

@emiflake emiflake force-pushed the emiflake/auth-check-support branch from 0863827 to 93c6bef Compare August 23, 2022 13:58
@emiflake emiflake force-pushed the emiflake/auth-check-support branch from 93c6bef to 2c068d9 Compare August 23, 2022 13:59
Copy link
Contributor

@chfanghr chfanghr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Let's merge it!

@emiflake emiflake enabled auto-merge August 23, 2022 14:12
@emiflake emiflake merged commit 0d88222 into staging Aug 23, 2022
@emiflake emiflake deleted the emiflake/auth-check-support branch November 7, 2022 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants