Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Witness stakes with reference input #168

Merged
merged 11 commits into from
Sep 13, 2022
Merged

Witness stakes with reference input #168

merged 11 commits into from
Sep 13, 2022

Conversation

chfanghr
Copy link
Contributor

@chfanghr chfanghr commented Aug 31, 2022 •
edited
Loading

@chfanghr chfanghr requested a review from emiflake August 31, 2022 14:36
@chfanghr chfanghr force-pushed the connor/witness-ref-stake branch 14 times, most recently from 2766a84 to 97cf16a Compare September 6, 2022 13:20
@chfanghr chfanghr force-pushed the connor/witness-ref-stake branch from 97cf16a to ddb4283 Compare September 6, 2022 13:25
@chfanghr chfanghr marked this pull request as ready for review September 6, 2022 13:52
emiflake
emiflake requested changes Sep 7, 2022
View reviewed changes
emiflake
emiflake reviewed Sep 7, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and add to the CHANGELOG.md ^^

emiflake
emiflake reviewed Sep 7, 2022
View reviewed changes
@chfanghr chfanghr force-pushed the connor/witness-ref-stake branch from ff1b3fb to 8e8a8f3 Compare September 7, 2022 13:56
emiflake
emiflake reviewed Sep 7, 2022
View reviewed changes
@chfanghr chfanghr force-pushed the connor/witness-ref-stake branch 2 times, most recently from 4666c7e to 335c6dd Compare September 7, 2022 14:10
emiflake
emiflake approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@emiflake
Copy link
Member

emiflake commented Sep 7, 2022

Building CI locally because hydra is broken.

@chfanghr
Copy link
Contributor Author

chfanghr commented Sep 7, 2022 •
edited
Loading

We should wait until the PCB pr gets merged, cause there're probably some API changes lying ahead😵

@emiflake
Copy link
Member

emiflake commented Sep 7, 2022

We should wait until the PCB pr gets merged, cause there're probably some API changes lying ahead

Oh, right. Let me know if you need my help.

@chfanghr chfanghr force-pushed the connor/witness-ref-stake branch from 335c6dd to 68a1360 Compare September 13, 2022 12:29
@chfanghr chfanghr enabled auto-merge September 13, 2022 12:30
@chfanghr chfanghr mentioned this pull request Sep 13, 2022
Merged
2 tasks
@chfanghr chfanghr merged commit de4e2ec into staging Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiflake emiflake emiflake approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference inputs for Stake witnessing
2 participants
@chfanghr @emiflake