Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the inclusiveness of the upper bound of txInfo.validRange in currentProposalTime #177

Merged

Conversation

chfanghr
Copy link
Contributor

@chfanghr chfanghr commented Sep 15, 2022

This pr is based on #176.

@chfanghr chfanghr requested a review from emiflake September 15, 2022 14:07
@chfanghr chfanghr force-pushed the connor/workaround-ctl-validity-interval-inclusiveness branch from 2860235 to fc31603 Compare September 15, 2022 14:15
@chfanghr chfanghr force-pushed the connor/workaround-ctl-validity-interval-inclusiveness branch from fc31603 to c7edb90 Compare September 15, 2022 14:30
@chfanghr chfanghr marked this pull request as ready for review September 15, 2022 14:35
@chfanghr chfanghr changed the title Ignore the inclusiveness of the lower bound of txInfo.validRange in currentProposalTime Ignore the inclusiveness of the upper bound of txInfo.validRange in currentProposalTime Sep 15, 2022
@chfanghr chfanghr force-pushed the connor/workaround-ctl-validity-interval-inclusiveness branch from 7b7a076 to 0fc33bd Compare September 15, 2022 14:39
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. The documentation will hopefully suffice to not have us forget this.

@emiflake emiflake merged commit 831ec90 into connor/fix-175 Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants