Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up governor scripts #181

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Clean up governor scripts #181

merged 2 commits into from
Sep 21, 2022

Conversation

chfanghr
Copy link
Contributor

@chfanghr chfanghr commented Sep 20, 2022 •
edited
Loading

  • Consistent identifier naming.
  • Reorganize code for better readability.
  • Remove unnecessary checks.
  • Governor validator: Fix a bug that allows an attacker to send two or more GATs to an effect in the winning effect group.
  • In some cases the script size goes up a little bit, unfortunately :(
  • It may be possible to optimize away by using some kind of set-like structure.

@chfanghr chfanghr requested a review from emiflake September 20, 2022 14:17
@chfanghr chfanghr marked this pull request as ready for review September 20, 2022 14:21
@chfanghr chfanghr force-pushed the connor/cleanup/governor branch 3 times, most recently from bee4ff7 to e58d8d3 Compare September 20, 2022 14:42
@chfanghr chfanghr force-pushed the connor/cleanup/governor branch from e58d8d3 to d92c062 Compare September 21, 2022 08:59
emiflake
emiflake approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The size increase makes sense considering it's doing more work 😅

@chfanghr chfanghr merged commit 16f3a61 into staging Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiflake emiflake emiflake approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chfanghr @emiflake