Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Voting with multiple stakes #186

Merged
merged 14 commits into from
Oct 5, 2022
Merged

Voting with multiple stakes #186

merged 14 commits into from
Oct 5, 2022

Conversation

chfanghr
Copy link
Contributor

@chfanghr chfanghr commented Sep 23, 2022 •
edited
Loading

Will close #184 and #44

@chfanghr chfanghr requested a review from emiflake September 23, 2022 09:12
@chfanghr chfanghr force-pushed the connor/vote-with-multiple-stakes branch 8 times, most recently from d42189c to 82ae84b Compare September 29, 2022 12:59
@chfanghr chfanghr force-pushed the connor/vote-with-multiple-stakes branch 8 times, most recently from 30e8719 to 4425143 Compare September 30, 2022 16:02
@chfanghr chfanghr linked an issue Sep 30, 2022 that may be closed by this pull request
Stake support for non-GT assets transparently #44
Closed
@chfanghr chfanghr force-pushed the connor/vote-with-multiple-stakes branch 3 times, most recently from 5efca44 to bf1d6fd Compare October 1, 2022 17:02
@chfanghr chfanghr marked this pull request as ready for review October 1, 2022 17:03
@chfanghr chfanghr force-pushed the connor/vote-with-multiple-stakes branch from bf1d6fd to 9bbb0c1 Compare October 3, 2022 09:22
@chfanghr chfanghr force-pushed the connor/vote-with-multiple-stakes branch from 9bbb0c1 to 26b5457 Compare October 3, 2022 11:15
emiflake
emiflake reviewed Oct 4, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is quite hard to review. Here are the comments I have so far. It generally looks good.

@chfanghr chfanghr force-pushed the connor/vote-with-multiple-stakes branch from 104c8b2 to 9bdb821 Compare October 4, 2022 14:03
@chfanghr chfanghr force-pushed the connor/vote-with-multiple-stakes branch from 9bdb821 to 6aa8051 Compare October 4, 2022 16:14
emiflake
emiflake approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@emiflake emiflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The voting threshold is implement exactly as I had in mind. Nice work!

@chfanghr chfanghr merged commit 4b9943f into staging Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emiflake emiflake emiflake approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow multiple votes to happen in a single transaction Stake support for non-GT assets transparently
2 participants
@chfanghr @emiflake