Fix vulnerabilities of staking components found by the audit team #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chfanghr
force-pushed
the
connor/audit-fix
branch
2 times, most recently
from
03c846c to
00798e6
Compare
emiflake
requested changes
Oct 17, 2022
emiflake
force-pushed
the
connor/audit-fix
branch
from
00798e6 to
96f40f9
Compare
chfanghr
force-pushed
the
connor/audit-fix
branch
from
96f40f9 to
8c40110
Compare
lukipuki
reviewed
Oct 18, 2022
| authorizedBy <- pletC $ pauthorizedBy # authorizationContext txInfoF | ||
|
|
||
| let ownerSignsTransaction = authorizedBy # firstStakeInputDatumF.owner | ||
| PPair allHaveSameOwner allHaveSameDelegatee <- | ||
| pmatchC $ |
There was a problem hiding this comment.
This refactoring works but it's less readable. Was it needed for performance purposes, e.g. there's only one pass through restOfStakeInputDatums instead of two?
There was a problem hiding this comment.
Yeah, exactly. We have to do manual list fusion in plutarch for now.
| pmatchC $ | ||
| pfoldr | ||
| # plam | ||
| ( \d p -> unTermCont $ do |
There was a problem hiding this comment.
Please use longer names, so that the reader can guess the types used, otherwise it's hard to read.
Suggested change
| ( \d p -> unTermCont $ do | |
| ( \stakeInputDatum pair -> unTermCont $ do |
There was a problem hiding this comment.
Great point. I will write that down.
| # pcon (PPair (pconstant True) (pconstant True)) | ||
| # restOfStakeInputDatums | ||
|
|
||
| let ownerSignsTransaction = |
There was a problem hiding this comment.
As far as I can see, the Privilege escalation: Acting on behalf of delegatee role issue has been resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.