Dont pass transaction in URL in multi signature continuous flow #5387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms state because bigger size is allowed in url state
ikem-legend
reviewed
Oct 16, 2023
ikem-legend
previously approved these changes
Oct 16, 2023
eniolam1000752
previously approved these changes
Oct 16, 2023
oskarleonard
dismissed stale reviews from eniolam1000752 and ikem-legend
via
fa978d6
eniolam1000752
approved these changes
Oct 16, 2023
ikem-legend
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #5374 #5388
How was it solved?
generateUniqueIdin the url.How was it tested?
Because of issue #5388 we unfortunately need to test all edge cases again to prevent regression in another state.
So please test the cases from this PR
As well as the issue raised in this issue #5388