Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added linkding widget #1106

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Added linkding widget #1106

merged 2 commits into from
Mar 2, 2023

Conversation

m42e
Copy link
Contributor

@m42e m42e commented Feb 13, 2023 •
edited by pull-request-badge bot
Loading

m42e Medium m42e /linkding → Lissy93/dashy Commits: 2 | Files Changed: 3 | Additions: 138 Label Unchecked Tasks

Thank you for contributing to Dashy! So that your PR can be handled effectively, please populate the following fields (delete sections that are not applicable)

Category:

Feature

Overview

List links provided by linkding, a selfhosted bookmarking service

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@vercel
Copy link

vercel bot commented Feb 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
dashy ❌ Failed (Inspect) Feb 14, 2023 at 6:06PM (UTC)

@netlify
Copy link

netlify bot commented Feb 13, 2023 •
edited
Loading

✅ Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit 281f173
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/63ebcd73d4e5460008c07723
😎 Deploy Preview https://deploy-preview-1106--dashy-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@viezly
Copy link

viezly bot commented Feb 13, 2023 •
edited
Loading

Changes preview:

Legend:

👀 Review pull request on Viezly

@m42e
Copy link
Contributor Author

m42e commented Feb 14, 2023

Selfhosted, so the links should be considerable good.

@m42e m42e marked this pull request as ready for review February 14, 2023 18:28
@m42e m42e requested a review from Lissy93 as a code owner February 14, 2023 18:28
@m42e
Copy link
Contributor Author

m42e commented Feb 22, 2023

@Lissy93 would you mind reviewing? Thanks!

1 similar comment
@m42e
Copy link
Contributor Author

m42e commented Feb 22, 2023

@Lissy93 would you mind reviewing? Thanks!

Lissy93
Lissy93 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Owner

@Lissy93 Lissy93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙌
Really sorry for the delay, I need to properly go through my notifications this weekend 😬

@Lissy93 Lissy93 merged commit 8fbf769 into Lissy93:master Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lissy93 Lissy93 Lissy93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m42e @Lissy93