-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Improved Search #175
Conversation
✔️ Deploy Preview for dashy-dev ready! 🔨 Explore the source changes: 490e8ed 🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/6122819279cd28000727216b 😎 Browse the preview: https://deploy-preview-175--dashy-dev.netlify.app/ |
This pull request is split into 4 parts for easier review. Changed files are located in these folders:
|
|| filterHelper(provider, searchTerm) | ||
|| filterHelper(description, searchTerm) | ||
|| filterHelper(tags, searchTerm) | ||
|| filterHelper(getDomainFromUrl(url), searchTerm); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W014: Misleading line break before '||'; readers may interpret this as an expression boundary.
(at-me in a reply with help
or ignore
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using AirBnB lint styleguide means that this is the approach enforced by ESLint
This pull request fixes 4 alerts when merging b0384d8 into 12b1143 - view on LGTM.com fixed alerts:
|
This pull request fixes 4 alerts when merging 490e8ed into 12b1143 - view on LGTM.com fixed alerts:
|
Category: Feature
Overview
Issue Number N/A
New Vars
item[n].tags
-string[]
Optional - An array of tags for a specific item, which can be used to find said itemScreenshot N/A
Code Quality Checklist (Please complete)