Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(windows): pin curl to working version #2618

Merged
merged 1 commit into from
May 31, 2024

Conversation

ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 31, 2024

Description

Pinning curl until msys2/MINGW-packages#21028 is resolved.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the build(windows)-pin-curl-to-working-version branch from e34a7db to 0405597 Compare May 31, 2024 21:55
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.01%. Comparing base (f0a00ae) to head (0405597).
Report is 158 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #2618      +/-   ##
=========================================
- Coverage    8.04%   7.01%   -1.04%     
=========================================
  Files          69      88      +19     
  Lines       13335   17987    +4652     
  Branches     6601    8579    +1978     
=========================================
+ Hits         1073    1261     +188     
- Misses      11252   13928    +2676     
- Partials     1010    2798    +1788     
Flag Coverage Δ
Linux 5.31% <ø> (ø)
Windows 2.61% <ø> (?)
macOS-12 8.01% <ø> (ø)
macOS-13 7.91% <ø> (ø)
macOS-14 8.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 50 files with indirect coverage changes

@ReenigneArcher ReenigneArcher marked this pull request as ready for review May 31, 2024 21:55
@ReenigneArcher ReenigneArcher merged commit 1a1833c into master May 31, 2024
49 checks passed
@ReenigneArcher ReenigneArcher deleted the build(windows)-pin-curl-to-working-version branch May 31, 2024 22:37
KuleRucket pushed a commit to KuleRucket/Sunshine that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant