Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steam Deck Gamingmode fix #711

Merged
merged 16 commits into from
Jan 25, 2023
Merged

Conversation

safijari
Copy link
Contributor

@safijari safijari commented Jan 5, 2023

Description

Added a function to check panel orientation in kmsgrab and for the case when the orientation is 270 implemented swapping width and height. This change allows the Steam deck gamingmode to stream correctly.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@CLAassistant
Copy link

CLAassistant commented Jan 5, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will also need to update the docs (i.e. Advanced Usage section).

I will try to find how to use a checkbox, but I think it's a bit more complicated.

src/platform/linux/kmsgrab.cpp Outdated Show resolved Hide resolved
src_assets/common/assets/web/config.html Outdated Show resolved Hide resolved
@psyke83
Copy link
Collaborator

psyke83 commented Jan 5, 2023

I'm not sure if this is a suitable fix?

There should be properties that can be queried to know the orientation. See drm_panel_orientation at: https://docs.kernel.org/gpu/drm-kms.html

@safijari
Copy link
Contributor Author

safijari commented Jan 18, 2023

@psyke83 I have removed the configuration option and instead do the width/height swap based on panel orientation. I have tested this on the steam deck and it works correctly. I can't test it on a regular landscape display because I'm an X11 peasant, but there isn't a reason to believe that would break. I'm not sure what to do with 90 and 270 as they require a flip to happen.

Edit: I tested the landscape orientation by connecting the Deck to a monitor. Everything works fine.

@safijari safijari marked this pull request as ready for review January 18, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants