Lowercase calculator with different operations #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kauter1989
suggested changes
Oct 11, 2023
| set(PROJECT_HEADERS Calculator_main.h, calcul.h) | ||
| add_executable(Calculator_main ${PROJECT_SOURCE_DIR}/ Calculator_main.cpp calcul.cpp "dll_read.cpp" "dll_read.h") | ||
|
|
||
| add_library(cos SHARED ./plugins/cos.cpp "plugins/cos.cpp" "dll_read.cpp" "dll_read.h") |
There was a problem hiding this comment.
Не должно быть прямых упоминаний библиотек в файлах сборки
| if ((number.size() != 0) || (operation.size() != 0)) std::cin.ignore();//extracting the viewed symbol from the stream | ||
| continue; | ||
| } | ||
| if ((c == 'c') || (c == 'l') || (c == 's') || (c == 't') || (c == 'r') || (c == 'a')) |
There was a problem hiding this comment.
Здесь производится проверка словили ли первый символ от нестандартной функции (sin, cos, ctg, tg и т.д.)
Потом считывается всё что до открывающейся скобки и записывается в map с операциями. Потом при обработке этих функций, если окажется что было считано, что-то не то (например, cas), то выведется исключение, что некорректно введено выражение.
There was a problem hiding this comment.
Зачем привязываться к первым буквам? Почему нельзя добавить синус через Sin(), как в таком случае добавить факториал, floor, fract... ?
| } | ||
| } | ||
| continue; | ||
| } |
| return; | ||
| } | ||
|
|
||
| bool calcul::check_neg(std::string c)//processing negative numbers if it is the first number in the expression or comes after the opening parenthesis |
There was a problem hiding this comment.
почему символ передается как контейнер?
Kauter1989
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.