Add support for Symbol action types #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Symbol doesn't support string concatenation, so first ensure action type is a string before logging.
imevro
pushed a commit
that referenced
this pull request
Aug 21, 2015
feat: add support for Symbol action types
|
It's not working because redux doesn't have support of Symbol. Reverted PR for now, frozen until redux's support. |
imevro
pushed a commit
that referenced
this pull request
Aug 22, 2015
|
Hey, my bad, have old redux (1.0.0-rc instead of 1.0.1) in example. Thanks for your PR! 1.0.4: https://github.com/fcomb/redux-logger/releases/tag/1.0.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on an app where we're using Symbols as the action types. Using redux-logger in this case throws an exception since Symbol doesn't support string concatenation. So this small patch manually coerces the action type to a string before attempting to log it.