Patch ModifyOrderRequestToWire #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the functionality and testing of order modifications in the
hyperliquid
package. The most important changes include adding support for spot orders in theModifyOrderRequestToWire
function, updating theBulkModifyOrders
method to handle spot orders, and adding a new test for modifying orders.Improvements to order modification functionality:
hyperliquid/convert.go
: Added support for spot orders in theModifyOrderRequestToWire
function by introducing anisSpot
parameter and adjusting asset ID and decimal precision based on the order type.hyperliquid/exchange_service.go
: Updated theBulkModifyOrders
method to accept anisSpot
parameter and pass it to theModifyOrderRequestToWire
function.Additions to testing:
hyperliquid/exchange_test.go
: Added a new test functionTestExchangeAPI_TestModifyOrder
to verify the functionality of modifying orders, including placing a limit order, modifying it, and then canceling all orders.Minor changes:
hyperliquid/exchange_test.go
: Added an import statement for thelog
package.