Skip to content

Conversation

0xBoringWozniak
Copy link
Member

This pull request includes several changes to improve the functionality and testing of order modifications in the hyperliquid package. The most important changes include adding support for spot orders in the ModifyOrderRequestToWire function, updating the BulkModifyOrders method to handle spot orders, and adding a new test for modifying orders.

Improvements to order modification functionality:

  • hyperliquid/convert.go: Added support for spot orders in the ModifyOrderRequestToWire function by introducing an isSpot parameter and adjusting asset ID and decimal precision based on the order type.
  • hyperliquid/exchange_service.go: Updated the BulkModifyOrders method to accept an isSpot parameter and pass it to the ModifyOrderRequestToWire function.

Additions to testing:

  • hyperliquid/exchange_test.go: Added a new test function TestExchangeAPI_TestModifyOrder to verify the functionality of modifying orders, including placing a limit order, modifying it, and then canceling all orders.

Minor changes:

@0xBoringWozniak 0xBoringWozniak added the bug Something isn't working label Jan 31, 2025
@0xBoringWozniak 0xBoringWozniak self-assigned this Jan 31, 2025
@0xBoringWozniak 0xBoringWozniak merged commit eb00557 into main Jan 31, 2025
@0xBoringWozniak 0xBoringWozniak deleted the patch-modify-order branch February 11, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant