OSOE-92: Upgrade module to Node Extensions #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Lombiq.VueJs/ResourceManagementOptionsConfiguration.cs
…SOE-92 # Conflicts: # Lombiq.VueJs.Samples/Lombiq.VueJs.Samples.csproj # Lombiq.VueJs.Samples/package.json # Lombiq.VueJs/Lombiq.VueJs.csproj
0liver
suggested changes
Oct 28, 2022
Co-authored-by: 0liver <0liver@users.noreply.github.com>
0liver
suggested changes
Oct 31, 2022
0liver
suggested changes
Oct 31, 2022
Comment on lines
4
to
8
| const args = process.argv.splice(2); | ||
| const argumentOptions = args.length >= 2 ? JSON.parse(args[1]) : undefined; | ||
|
|
||
| async function executeFunctionByCommandLineArgument(functions) { | ||
| if (!args[0]) return; |
There was a problem hiding this comment.
I'm lost here.
- Is
argspopulated when we callexecuteFunctionByCommandLineArgumentdirectly, as we do in the compiler pipeline scripts? - Does
argscontain anything else thanfunctionsitself? - What is
argumentOptionsgoing to look like?
Please enlighten me!
There was a problem hiding this comment.
- Args is the command line arguments from
process.argv, basically runtime constants. - It contains the name of the function, see here. Optionally it could contain a JSON that will expand the
defaultOptions(e.g. custom root path, further rollup aliases). Configuring the options is not needed now, but iirc we needed it in Finitive (with GE) and may need it in the future. { "sfcRootPath": "Assets/Vue", "rollupAlias": { "batman": "../../../batman" } }(see traditional batman example)
There was a problem hiding this comment.
I've refactored the function with more destructuring and explicit error messages to be cleaner and more developer-friendly.
Co-authored-by: 0liver <0liver@users.noreply.github.com>
0liver
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSOE-92