fails to connect after restoring peripheral from state

[thebookins]

I have noticed at times that when I run the example app with the same transmitter ID as a previous session, the app fails to scan or connect. Rather than seeing the expected log messages (Scanning for peripherals or Reconnecting to known peripheral ... in 180.0 s) I just see the message Restoring peripheral from state .... This is on latest dev and iOS 11.2.5.

[ps2]

This is intended behavior; state restoration is spinning up correctly. Are you actually seeing issues if you wait for up to the 5 minute cycle?

[thebookins]

Yeah, I’ve tried waiting for several 5 minute cycles and it never connects.

[thebookins]

I investigated a bit further, and found that when the peripheral is restored from state, the CBPeripheralState is .connecting. So it falls over at this guard statement and we don't end up scanning.

I tried disconnecting from the peripheral in deinit (i.e. like before #72) but no difference. I'm not sure what the best solution is; would it work to add .connecting to the list of acceptable states?

[ps2]

Guessing in the dark: there could be an issue where a restored CBPeripheral has a state of .connecting but that connect request needs to be re-instated. This sounds like a potential Core Bluetooth bug.

A fix could be to allow BluetoothManager to re-ask a peripheral in the .connecting state to connect; I can't imagine any negative consequences of that.

See https://github.com/LoopKit/xDripG5/tree/allow-reconnect-when-connecting for a diff that tweaks the guard statement slightly for that case.

[thebookins]

Should do the trick. Thanks.

[thebookins]

Haven't had any issues since #82, which implements the new guard statement. Thanks. Closing.