Add Integral Retrospective Correction Option to Algorithm Experiments #2008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isolation of code and storage, moved toggle to Experimental Section
|
The controls are found on the Loop Settings screen in the Algorithm Experiments section.
|
|
The explanation screen is currently as shown. I will update this comment with a new graphic when this is revised.
|
Removed unnecessary xcscheme files, Moved up algorithmExperimentsSection
copy paste error
Dark mode fix
* Add Dosing Strategy: automaticBolusSlidingScale * Reverse order of two new constants * revert to dev for dosing strategy selection * revert to dev for dosing strategy selection * Rename to effectiveBolusApplicationFactor, change to flag inside existing automaticBolus case * Add applyLinearRamp slider to Dosing Strategy * Update constants * Modify explanation seen by user * missed one phrase * Update explanation seen by user, modify font * Enable swapping of original and replacment protocols, minimize LoopKit changes * Restore to dev branch version prior to pr1988_update merge * Restore to dev branch version prior to update for PR 1988 * Updates per requested changes for Loop PR 1988 * Renaming, adjusting views, logging * Wording change * Logging error fixed * dead code * missed rename * dark mode fix * Updated algorithm experiments view and glucose based partial application view * Put algorithm experiments behind feature flag --------- Co-authored-by: Jonas Björkert <jonas@bjorkert.se> Co-authored-by: Pete Schwamb <pete@schwamb.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The adds the Integral Retrospective Correction (IRC) option to Algorithm Experiments in Loop Settings.
The underlying IRC code is from @dm61 and has been wrapped in the structure to match the configuration used for PR #1988.
Please see #695 for #dm61 original proposal.