Skip to content

Conversation

marionbarker
Copy link
Contributor

Update SHA for DanaKit

@marionbarker
Copy link
Contributor Author

Summary

The previous feat/dana version would successfully build on iOS 15, 16 and 18 phones but for iOS 15 and 16 phones, the option to select Dana as a pump was not shown. For the iOS 18 phone, the option was shown and worked as expected.

This PR modifies the minimum iOS deployment to 15.1 and runs successfully on multiple Loop test phones.

Test

Configuration for Loop:

  • test for 3 phones:
    • iPhone 7 plus, iOS 15.8.4
    • iPhone 8, iOS 16.7.11
    • iPhone SE 3rd gen, iOS 18.6.1
  • initial branch feat/dana, 310263e uses SHA 54892d8 from DanaKit
  • create new branch update_dana, 53d5b37
    • DanaKit SHA 33a8d47, loopandlearn/DanaKit dev branch
    • this commit uses a minimum deployment of 15.1 (previously was set to 18.1)

Test:

Confirm for each phone:

  • iOS 15 phone:
    [y] build
    [y] add Dana, rPi simulator
    [y] green loop
    [y] delete Dana
    [y] add pump simulator

  • iOS 16 phone:
    [y] build
    [y] add Dana, rPi simulator
    [y] green loop
    [y] delete Dana
    [y] add pump simulator

  • iOS 18 phone:
    [y] build
    [y] add Dana, rPi simulator
    [y] green loop
    [y] delete Dana
    [y] add pump simulator

@marionbarker marionbarker merged commit 3a3a2b0 into feat/dana Aug 20, 2025
1 check was pending
@marionbarker marionbarker deleted the update_dana branch September 2, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant