[Protocol3] Batched proof verification #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/loopring_v3/ABI/version30/IExchange.abi # packages/loopring_v3/contracts/iface/IExchange.sol # packages/loopring_v3/test/testExchangeBlocks.ts
# Conflicts: # packages/lightcone_v2.js/src/lib/wallet/ethereum/walletAccount.ts # packages/lightcone_v2.js/src/sign/exchange.ts # packages/lightcone_v2.js/src/wallet/metaMask.ts
|
@dong77 Ready for review. Unfortunately this PR has an extremely messy diff because of the automatic formatting that is now done when committing. |
@Brechtpd no worries. @letsgoustc and myself will probably need a week to review this PR. Please be patient. |
dong77
approved these changes
Jul 24, 2019
dong77
previously approved these changes
Jul 25, 2019
| require(circuit.enabled == true, "ALREADY_DISABLED"); | ||
| circuit.enabled = false; | ||
|
|
||
| emit CircuitDisabled(blockType, onchainDataAvailability, blockSize, blockVersion); |
| circuit.registered = true; | ||
| circuit.enabled = true; | ||
|
|
||
| emit CircuitRegistered(blockType, onchainDataAvailability, blockSize, blockVersion); |
| ExchangeData.State storage S, | ||
| uint blockIdx, | ||
| uint256[8] memory proof | ||
| uint[] memory blockIndices, |
There was a problem hiding this comment.
should we check the max length of blockIndies?
There was a problem hiding this comment.
There is no hard limit (except for the Ethereum gas limit/block). There's also a good chance verifying a proof will get even cheaper in Istanbul so it's up to the operator to decide how many proofs can be successfully verified.
letsgoustc
previously approved these changes
Jul 25, 2019
dong77
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the cost of verifying a proof from 550,000 gas/proof to about 200,000 gas/proof.