-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Loopring3] refactor deployment process to support upgradability #384
Conversation
dong77
commented
Aug 8, 2019
•
edited
Loading
edited
- ABI files will be generated automatically before tests run, so they are deleted from git.
- LoopringRegistry now maintains the ids of all exchanges (cross-version) and will burn LRC when an exchange is created, LoopringV3.sol only maintains exchanges based on LoopringV3.
packages/loopring_v3/contracts/impl/libexchange/ExchangeData.sol
Outdated
Show resolved
Hide resolved
Another way to lower the deployment cost is to lower the number of 'runs' in the optimizer here (delete all build files of contracts because truffle isn't always smart enough to recompile the contracts). This normally also increases the gas cost of actually using the functions, but not making functions |
Good to know. But now we are good to go. Not sure what will happen after we introduce more features. |
@kongliangzhong can you review the IProtocolRegistry and ProtocolRegistry for me? |