Added TypeScriptCompile to CollectedFiles. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're right! I remember seeing @(TypeScriptCompile) in the Octopack target, but it looks like I forgot about it. Thank you very much! |
|
I was a little confused for a while. I was guessing that @(TypeScriptCompile) contains the output of the TypeScript compiler (which would be a real problem to ignore), but it contains the TypeScript source files. I noticed that the Octopack target contains a flag (OctoPackIncludeTypeScriptSourceFiles) to instruct Octopack whether to include the TypeScript source files or not. It's false by default. I'm not sure what is exactly the use case. When would someone want to deploy their TypeScript source files? Anyway, the goal is really to follow the original behavior, so I added the condition. See de52049. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your comment states that CollectedFiles should collect the files the same way as OctoPack but you did not include
@(TypeScriptCompile)(https://github.com/OctopusDeploy/OctoPack/blob/abd0c5d30cfd0572ff066b83436969661b9cdbd4/source/tools/OctoPack.targets#L73) and this patch adds that. You might want to change your comment if you did not include this on purpose.