Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate utils from config/ scripts #662

Merged
merged 10 commits into from
Oct 19, 2023
Merged

Generate utils from config/ scripts #662

merged 10 commits into from
Oct 19, 2023

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Oct 19, 2023

Description

#658 inspired me to fold in the contents of scripts in config/ into either settings.py or a new database_settings util

  • Fixes call on module error in dj_config.py  #658 : Changes os.path for pathlib and integrates with existing config manager class
    • settings.py: New methods for writing a dj_config with lab defaults and custom fields
  • Fixes: Merging utilities into the codebase
    • utils/database_settings.py: New class to manage redundancy across existing scripts
    • config/*: rely on new class, flag depreciation

Checklist:

  • This PR should be accompanied by a release: No
  • I have updated the CHANGELOG.md:
  • I have added/edited docs/notebooks to reflect the changes

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CBroz1 CBroz1 marked this pull request as ready for review October 19, 2023 21:08
@edeno edeno merged commit 0a49b12 into LorenFrankLab:master Oct 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

call on module error in dj_config.py
2 participants