Skip to content

Conversation

moteus
Copy link
Member

@moteus moteus commented Sep 27, 2016

Close #78

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 64.578% when pulling e7f83e7 on moteus:master into 90c1777 on Lua-cURL:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 64.578% when pulling e7f83e7 on moteus:master into 90c1777 on Lua-cURL:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 64.578% when pulling e7f83e7 on moteus:master into 90c1777 on Lua-cURL:master.

@coveralls
Copy link

coveralls commented Sep 27, 2016

Coverage Status

Coverage increased (+0.7%) to 64.43% when pulling a836734 on moteus:master into 90c1777 on Lua-cURL:master.

@moteus moteus added the bug label Sep 27, 2016
@coveralls
Copy link

coveralls commented Sep 27, 2016

Coverage Status

Coverage increased (+0.8%) to 64.46% when pulling 9a1270f on moteus:master into 90c1777 on Lua-cURL:master.

@coveralls
Copy link

coveralls commented Sep 27, 2016

Coverage Status

Coverage increased (+0.7%) to 64.43% when pulling b2e9474 on moteus:master into 90c1777 on Lua-cURL:master.

@uudiin
Copy link
Contributor

uudiin commented Sep 28, 2016

It will still crash in some case.
It creashed in lcurl_multi_timer_callback with p->L = NULL.

@moteus
Copy link
Member Author

moteus commented Sep 28, 2016

Did you can figureout from which curl function it called?

@uudiin
Copy link
Contributor

uudiin commented Sep 28, 2016

lua_gettop(lua_State * L) 行 118 C
lcurl_multi_timer_callback(void * multi, long ms, void * arg) 行 420 C
update_timer(Curl_multi * multi) 行 2806 C
curl_multi_remove_handle(Curl_multi * multi, Curl_easy * data) 行 780 C
lcurl_multi_info_read(lua_State * L) 行 216 C
...
lua_pcall(lua_State * L, int nargs, int nresults, int errfunc) 行 1052 C
luv_call_callback(lua_State * L, luv_handle_t * data, int id, int nargs) 行 96 C
luv_poll_cb(uv_poll_s * handle, int status, int events) 行 80 C
uv__fast_poll_process_poll_req(uv_loop_s * loop, uv_poll_s * handle, uv_req_s * req) 行 219 C
uv_process_poll_req(uv_loop_s * loop, uv_poll_s * handle, uv_req_s * req) 行 623 C
uv_process_reqs(uv_loop_s * loop) 行 206 C
uv_run(uv_loop_s * loop, uv_run_mode mode) 行 391 C
luv_run(lua_State * L) 行 33 C
...
lua_pcall(lua_State * L, int nargs, int nresults, int errfunc) 行 1052 C
docall(lua_State * L, int narg, int clear) 行 124 C
handle_script(lua_State * L, char * * argv, int n) 行 291 C
pmain(lua_State * L) 行 540 C
...
lua_cpcall(lua_State * L, int(*)(lua_State *) func, void * ud) 行 1074 C
main(int argc, char * * argv) 行 568 C

@uudiin
Copy link
Contributor

uudiin commented Sep 28, 2016

I use luajit.

Fix. Support nested callbacks.
Fix. Cleanup easy references when calls multi::close.
Add. `__tostring` method for handles.
@coveralls
Copy link

coveralls commented Sep 28, 2016

Coverage Status

Coverage increased (+0.6%) to 64.319% when pulling 367eb14 on moteus:master into 90c1777 on Lua-cURL:master.

@moteus
Copy link
Member Author

moteus commented Sep 28, 2016

Please test last commit

@uudiin
Copy link
Contributor

uudiin commented Sep 28, 2016

It's OK. I have tested already.

Change. Do not reset Lua state back to NULL.
@coveralls
Copy link

coveralls commented Sep 28, 2016

Coverage Status

Coverage increased (+0.8%) to 64.486% when pulling 78a4a03 on moteus:master into 90c1777 on Lua-cURL:master.

@coveralls
Copy link

coveralls commented Sep 28, 2016

Coverage Status

Coverage increased (+0.8%) to 64.532% when pulling c5e4734 on moteus:master into 90c1777 on Lua-cURL:master.

@moteus moteus merged commit 2798a61 into Lua-cURL:master Sep 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants