Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

performance issue #1192

Closed
sumneko opened this issue Jun 7, 2022 · 8 comments
Closed

performance issue #1192

sumneko opened this issue Jun 7, 2022 · 8 comments
Labels
performance Related to the performance of the langauge server
Milestone
3.3.0

Comments

@sumneko
Copy link
Collaborator

sumneko commented Jun 7, 2022 

"Lua.workspace.library": [
    "${3rd}/Jass/library"
]
@sumneko sumneko added the performance Related to the performance of the langauge server label Jun 7, 2022
@sumneko sumneko added this to the 3.3.0 milestone Jun 7, 2022
@sumneko
Copy link
Collaborator Author

sumneko commented Jun 7, 2022

CPU: Intel(R) Core(TM) i7-10700F CPU @ 2.90GHz
Benchmark [largeGlobal.txt] takes 12.1 sec

sumneko added a commit that referenced this issue Jun 7, 2022
@sumneko
#1192 improve local id
ba6cecf 
In most cases, we only need to get `sets`. In general, there are few `sets` and many `gets`.
Therefore, separating these two cases can significantly improve performance.
@sumneko
Copy link
Collaborator Author

sumneko commented Jun 7, 2022

CPU: Intel(R) Core(TM) i7-10700F CPU @ 2.90GHz
Benchmark [largeGlobal.txt] takes 6.6 sec

sumneko added a commit that referenced this issue Jun 7, 2022
@sumneko
#1192 don't search local in simple
07bdb57 
use the methods provided by `local-id` to avoid wasting on `gets`
@sumneko
Copy link
Collaborator Author

sumneko commented Jun 7, 2022

CPU: Intel(R) Core(TM) i7-10700F CPU @ 2.90GHz
Benchmark [largeGlobal.txt] takes 1.3 sec

sumneko added a commit that referenced this issue Jun 7, 2022
@sumneko
#1192 add benchmark for jass.common
7fa53c5
@sumneko
Copy link
Collaborator Author

sumneko commented Jun 7, 2022

CPU: Intel(R) Core(TM) i7-10700F CPU @ 2.90GHz
Benchmark [jass-common.txt] takes 10.9 sec

sumneko added a commit that referenced this issue Jun 7, 2022
@sumneko
#1192 improve performance
ec39447 
`guide.getLocal` is too slow
@sumneko
Copy link
Collaborator Author

sumneko commented Jun 7, 2022

CPU: Intel(R) Core(TM) i7-10700F CPU @ 2.90GHz
Benchmark [jass-common.txt] takes 0.3 sec

sumneko added a commit that referenced this issue Jun 7, 2022
@sumneko
#1192 add benchmark for completion jass.common
cd23038
@sumneko
Copy link
Collaborator Author

sumneko commented Jun 7, 2022

Benchmark [performance-1] takes [0.854] sec.

sumneko added a commit that referenced this issue Jun 7, 2022
@sumneko
#1192 improve test
83b2804
@sumneko
Copy link
Collaborator Author

sumneko commented Jun 7, 2022

Benchmark [performance-jass-common] takes [10.266] sec.

sumneko added a commit that referenced this issue Jun 7, 2022
@sumneko
#1192 improve [[--@as number]]
4b87fcf 
cache ases and search with dichotomy
@sumneko
Copy link
Collaborator Author

sumneko commented Jun 7, 2022

Benchmark [performance-jass-common] takes [0.073] sec.

@sumneko sumneko closed this as completed Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
performance Related to the performance of the langauge server
Projects
None yet
Milestone
3.3.0
Development

No branches or pull requests
1 participant
@sumneko