Skip to content

latest commit keeps asking for checkThirdParty #2407

@gennaro-tedesco

Description

@gennaro-tedesco

How are you using the lua-language-server?

NeoVim

Which OS are you using?

MacOS

What is the issue affecting?

Other

Expected Behaviour

checkThirdParty = "false"

behaves correctly avoiding asking to check third party if the option is set to false/"false" (or similar grammar)

Actual Behaviour

The latest commit seems to not take effect, and checkThirdParty is asked all the times despite setting it to either of the strings false.

My language server configuration looks like the following:

...
lsp.lua_ls.setup({
	capabilities = capabilities,
	on_attach = on_attach,
	lsp_flags = lsp_flags,
	settings = {
		Lua = {
			format = { enable = false },
			hint = { enable = true },
			runtime = { version = "LuaJIT" },
			diagnostics = { globals = { "describe", "it", "vim", "setup", "teardown" } },
			workspace = { library = vim.api.nvim_get_runtime_file("", true), checkThirdParty = "false" },
			telemetry = { enable = false },
		},
	},
})

is my option for checkThirdParty set correctly?

Reproduction steps

  1. set language server options to workspace = { library = vim.api.nvim_get_runtime_file("", true), checkThirdParty = "false" },
  2. open neovim with any .lua file
  3. the language server keeps asking to check third party packages

Additional Notes

As edit to the original message, the configuration does work when setting the option to "Disable".

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions