Don't override lm.bindir and lm.EXE_DIR in make.lua #1977
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, the targets
/main.lua
and/bootstrap.lua
inbuild/build.ninja
were being generated, which in turn caused access violations during the build. I was having problems building on Gentoo because of this (their package manager sandboxes their builds).To illustrate, here's a diff of
build/build.ninja
generated before and after this change.I also had to add the
copy_lua-language-server
rule both to retain the previous behavior of placing the executable in bin/, but also because without it ninja complains that there are two rules formain.lua
.