meta:fix jit module #2111
Merged
meta:fix jit module #2111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C3pa
reviewed
May 15, 2023
| ---@field os string | ||
| ---@field arch string | ||
| ---@field os 'Windows'|'Linux'|'OSX'|'BSD'|'POSIX'|'Other' | ||
| ---@field arch 'x86'|'x64'|'arm'|'arm64'|'arm64be'|'ppc'|'ppc64'|'ppc64le'|'mips'|'mipsel'|'mips64'|'mips64el'|string |
There was a problem hiding this comment.
Is there a reason you left |string at the end of this union?
There was a problem hiding this comment.
Some branches support other architectures
There was a problem hiding this comment.
That's a valid reason. Thanks for the explanation.
| local profile = {} | ||
|
|
||
| ---@param mode string | ||
| ---@param func fun(L:thread,samples:integer,vmst:string) |
There was a problem hiding this comment.
Can you insert some spaces into your fun() annotations in this file?
---@param func fun(L: thread, samples: integer, vmst: string)There was a problem hiding this comment.
This feature is not supported by formater. You can contribute these changes into the pull.Thanks
| function profile.stop() | ||
| end | ||
|
|
||
| ---@overload fun(th:thread,fmt:string,depth:integer) |
| function util.tracemc(tr) | ||
| end | ||
|
|
||
| ---@overload fun(exitno:integer):integer |
There was a problem hiding this comment.
---@overload fun(exitno: integer): integer
|
我对LuaJIT不太了解，这个PR是否已准备好合并了？ |
可以合并了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.