Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace meta 3rd with LuaCATS submodules #2237

Merged
merged 14 commits into from Oct 28, 2023

Conversation

carsakiller
Copy link
Collaborator

This replaces all the included addons with their LuaCATS mirror as submodules. Until they are removed, this should help us keep one source of truth up to date and in sync.

I'm not sure, but I am assuming there will need to be an additional step added to the build process that retrieves all of these submodules for compiling.

luv and ffi-reflect do not yet have LuaCATS mirrors, so they have not been swapped out.

@carsakiller carsakiller added the feat/addon Related to addons label Jul 29, 2023
@carsakiller
Copy link
Collaborator Author

@sumneko thoughts on this? Will there need to be modifications to the build/publish workflows in order to pull all of these submodules?

@sumneko
Copy link
Collaborator

sumneko commented Aug 21, 2023

Maybe you can just put them into meta/3rd ?

@carsakiller
Copy link
Collaborator Author

They are? I don't think I understand.

@sumneko
Copy link
Collaborator

sumneko commented Aug 23, 2023

They are? I don't think I understand.

I was mistaken. This PR is indeed in the form I expected.

@sumneko
Copy link
Collaborator

sumneko commented Oct 10, 2023

Is this ready?

@carsakiller
Copy link
Collaborator Author

I have not yet moved luv and ffi-reflect to LuaCATS, but also, I am unsure of if the submodules will be bundled into the release properly. Do I need to change any configuration files to make sure that these submodules are initialized during the build and included in the release?

@sumneko
Copy link
Collaborator

sumneko commented Oct 18, 2023

Do I need to change any configuration files to make sure that these submodules are initialized during the build and included in the release?

I'm not sure either. However, we can observe the build results and fix any issues that arise.

@carsakiller carsakiller force-pushed the replace-meta-3rd-with-submodules branch from c4538a7 to fb9253f Compare October 28, 2023 00:42
@carsakiller carsakiller marked this pull request as ready for review October 28, 2023 00:42
@carsakiller carsakiller self-assigned this Oct 28, 2023
@carsakiller
Copy link
Collaborator Author

Should be ready to go!

@sumneko sumneko merged commit 6af9400 into LuaLS:master Oct 28, 2023
7 checks passed
@carsakiller carsakiller deleted the replace-meta-3rd-with-submodules branch October 30, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat/addon Related to addons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants