Skip to content

fix: respect ignoreDir in --check CLI #3110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 12, 2025
Merged

fix: respect ignoreDir in --check CLI #3110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2039695
fix: respect ignoreDir in --check CLI
emmericp Mar 8, 2025
19548fc
Merge branch 'master' into fix-ignore-in-check
emmericp Mar 9, 2025
63f7676
Merge branch 'master' into fix-ignore-in-check
sumneko Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
<!-- Add all new changes here. They will be moved under a version at release -->
* `CHG` When analyzing the literal table, only the first 100 items are analyzed at most.
* `CHG` When checking type matching for union types, only the first 100 items are checked at most.
* `FIX` --check now respects ignoreDir setting
* `FIX` incorrect argument skip pattern for `--check_out_path=`, which incorrectly skips the next argument

## 3.13.7
`2025-3-10`
Expand Down
2 changes: 1 addition & 1 deletion script/cli/check_worker.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ function export.runCLI()
local max = #uris
table.sort(uris) -- sort file list to ensure the work distribution order across multiple threads
for i, uri in ipairs(uris) do
if (i % numThreads + 1) == threadId then
if (i % numThreads + 1) == threadId and not ws.isIgnored(uri) then
files.open(uri)
diag.doDiagnostic(uri, true)
-- Print regularly but always print the last entry to ensure
Expand Down