Add support for multipart/form-data
bodies
#258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the change. If there is an associated issue, please include the issue link (e.g. "Closes #xxx"). For UI changes, please also include screenshots.
This adds first-class support for
multipart/form-data
bodies, similar to the existingapplication/x-www-form-urlencoded
bodies. This one was a bit more complicated, mainly because reqwest forces the body to be a stream rather than binary blob when using themultipart
builder. So we're forced to turn plain bytes into a stream. This is annoying now but leaves us in an ok spot for #256. An example:Closes #243
Known Risks
What issues could potentially go wrong with this change? Is it a breaking change? What have you done to mitigate any potential risks?
I haven't tested this much so there's totally room for an edge case. Also large files are forced to be loaded entirely into memory, which could create issues for some people.
QA
How did you test this?
Checklist
CONTRIBUTING.md
already?CHANGELOG.md
?