Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shareable stylelint package for lucca-front. #2745

Open
wants to merge 82 commits into
base: rc
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
b8b99af
[Stylelint] Create shareable package for lucca-front.
fbasmaison-lucca Apr 19, 2024
52fb810
[Stylelint] Use legacy notation for colors (`rgba` instead of `rgb`).
fbasmaison-lucca Apr 25, 2024
6e89467
[Stylelint] Update documentation:
fbasmaison-lucca Apr 25, 2024
b9779a2
[Stylelint] Add Code owners.
fbasmaison-lucca Apr 25, 2024
2f5eb4f
[Stylelint] Fix a typo.
fbasmaison-lucca Apr 25, 2024
25ff274
chore(stylelint): Update stylelint and its rules.
fbasmaison-lucca Jan 14, 2025
48529ef
chore(stylelint): Add SCSS linting in Jenkins.
fbasmaison-lucca Jan 14, 2025
5c88d09
ci(jenkins): Add stylelint to dev dependencies for Jenkins.
fbasmaison-lucca Jan 14, 2025
30d5af2
fix(stylelint): Cancel 'value-keyword-case' to give us more freedom.
fbasmaison-lucca Jan 14, 2025
756c2f2
feature(stylelint): Add LF features deprecation linting (hardcoded).
fbasmaison-lucca Jan 14, 2025
66e9ae4
fix(stylelint): scss/load-no-partial-leading-underscore errors.
fbasmaison-lucca Jan 14, 2025
e337206
fix(stylelint): Ignore files used to test.
fbasmaison-lucca Jan 14, 2025
d35d21c
doc(stylelint): Fix documentation to adapt to Jenkins needs.
fbasmaison-lucca Jan 14, 2025
bba0f0c
ci(stylelint): Cancel all faulty rules.
fbasmaison-lucca Jan 14, 2025
3680cc1
ci(stylelint): Fix `declaration-block-no-duplicate-properties` errors.
fbasmaison-lucca Jan 14, 2025
956c2b2
ci(stylelint): Fix `scss/no-duplicate-mixins` errors.
fbasmaison-lucca Jan 14, 2025
67202d6
ci(stylelint): Move `no-duplicate-selectors` rule to project.
fbasmaison-lucca Jan 14, 2025
ecf418a
ci(stylelint): Fix `no-irregular-whitespace` errors.
fbasmaison-lucca Jan 14, 2025
e4509f0
ci(stylelint): Move `no-descending-specificity` to project.
fbasmaison-lucca Jan 14, 2025
032a879
ci(stylelint): Fix `scss/no-global-function-names` errors.
fbasmaison-lucca Jan 14, 2025
480043e
ci(stylelint): Fix `scss/double-slash-comment-whitespace-inside` errors.
fbasmaison-lucca Jan 14, 2025
310a0ec
ci(stylelint): Fix `scss/double-slash-comment-empty-line-before` errors.
fbasmaison-lucca Jan 14, 2025
7ee9538
ci(stylelint): Fix `at-rule-empty-line-before` errors…
fbasmaison-lucca Jan 14, 2025
137771d
ci(stylelint): Move `block-no-empty` to project.
fbasmaison-lucca Jan 14, 2025
ca79500
ci(stylelint): Fix `scss/dollar-variable-empty-line-before` errors…
fbasmaison-lucca Jan 14, 2025
5e007dc
ci(stylelint): Fix `rule-empty-line-before` errors.
fbasmaison-lucca Jan 14, 2025
d71220c
ci(stylelint): Fix `comment-empty-line-before` errors.
fbasmaison-lucca Jan 14, 2025
379aa23
ci(stylelint): Move `scss/at-mixin-argumentless-call-parentheses` to …
fbasmaison-lucca Jan 14, 2025
84f2988
ci(stylelint): Move `scss/at-mixin-pattern` to project.
fbasmaison-lucca Jan 14, 2025
6ef0a95
ci(stylelint): Fix `shorthand-property-no-redundant-values` errors.
fbasmaison-lucca Jan 14, 2025
1d673ad
ci(stylelint): Fix `selector-pseudo-element-colon-notation` errors.
fbasmaison-lucca Jan 14, 2025
9b95052
ci(stylelint): Move `scss/at-rule-no-unknown` to project.
fbasmaison-lucca Jan 14, 2025
5103af3
ci(stylelint): Move `scss/at-rule-conditional-no-parentheses` to proj…
fbasmaison-lucca Jan 14, 2025
90a7694
ci(stylelint): Move `selector-not-notation` to project.
fbasmaison-lucca Jan 14, 2025
8a01960
ci(stylelint): Fix `length-zero-no-unit` errors.
fbasmaison-lucca Jan 14, 2025
33a124f
ci(stylelint): Move `font-family-no-missing-generic-family…` to project.
fbasmaison-lucca Jan 14, 2025
35f5cd8
ci(stylelint): Fix `no-empty-source` errors…
fbasmaison-lucca Jan 14, 2025
992506a
ci(stylelint): Move `property-no-vendor-prefix` to project.
fbasmaison-lucca Jan 14, 2025
aa64993
ci(stylelint): Fix `custom-property-pattern` errors.
fbasmaison-lucca Jan 14, 2025
929e443
ci(stylelint): Fix `declaration-property-value-disallowed-list` errors.
fbasmaison-lucca Jan 14, 2025
d4ace50
ci(stylelint): Comment rules nullification and trigger errors.
fbasmaison-lucca Jan 14, 2025
d713229
chore(stylelint): Upgrade stylelint to latest version.
fbasmaison-lucca Jan 27, 2025
b79ede1
ci(stylelint): Ignore `custom-property-empty-line-before` on vars.scss.
fbasmaison-lucca Jan 27, 2025
111da1b
ci(stylelint): Run `npx stylelint packages/**/*.scss --fix` errors…
fbasmaison-lucca Jan 27, 2025
b781d34
ci(stylelint): Fix `at-rule-empty-line-before` errors after rebase.
fbasmaison-lucca Jan 29, 2025
041349d
ci(stylelint): Fix duplicated `@use` after rebase.
fbasmaison-lucca Jan 29, 2025
176ebf0
ci(stylelint): Fix `font-family-no-missing-generic-family-keyword`.
fbasmaison-lucca Jan 29, 2025
12fee86
fix(stylelint): Use regular expressions for values:
fbasmaison-lucca Jan 29, 2025
770dad5
chore(stylelint): Upgrade stylelint to latest version.
fbasmaison-lucca Jan 30, 2025
2581443
fix(stylelint): Handle cases where version or date are invalid…
fbasmaison-lucca Jan 31, 2025
fe70fde
fix(stylelint): The status is not deleted before deletion days…
fbasmaison-lucca Jan 31, 2025
f835f94
Merge branch 'rc' into stylelint
fbasmaison-lucca Jan 31, 2025
2fa2eca
Merge branch 'rc' into stylelint
fbasmaison-lucca Feb 3, 2025
ba06dad
Merge branch 'rc' into stylelint
fbasmaison-lucca Feb 5, 2025
d0f4404
review + fix
vvalentin-lucca Feb 5, 2025
c2b87c3
no-duplicate-selectors
vvalentin-lucca Feb 5, 2025
1a1f1a6
property-no-vendor-prefix
vvalentin-lucca Feb 5, 2025
412bff8
scss/at-mixin-argumentless-call-parentheses
vvalentin-lucca Feb 5, 2025
78d3212
scss/at-mixin-pattern
vvalentin-lucca Feb 5, 2025
353add8
scss/at-rule-conditional-no-parentheses
vvalentin-lucca Feb 5, 2025
a38bdca
scss/at-rule-no-unknown
vvalentin-lucca Feb 5, 2025
0a83db2
selector-not-notation
vvalentin-lucca Feb 5, 2025
ae2298f
no-descending-specificity
vvalentin-lucca Feb 5, 2025
4875869
revert deprecated
vvalentin-lucca Feb 5, 2025
6bcdcc1
fix(stylelint): Allow the use of `.button.palette-error.mod-icon`:
fbasmaison-lucca Feb 5, 2025
b718004
doc(stylelint): Better document VS-code fix for `//` bug.
fbasmaison-lucca Feb 6, 2025
dc8743f
Merge branch 'rc' into stylelint
fbasmaison-lucca Feb 7, 2025
bac976b
ci(stylelint): Address stylelint violations:
fbasmaison-lucca Feb 10, 2025
c7e1c91
feat: get milestone dates from github API
Supamiu Feb 11, 2025
6d02f6c
chore(stylelint): Order rules alphabetically.
fbasmaison-lucca Feb 11, 2025
c940267
chore: add github milestone cache
Supamiu Feb 11, 2025
af70849
feat(stylelint): Add `CACHE_FILE_PATH` to `console.log()`.
fbasmaison-lucca Feb 12, 2025
81d97ee
feat: read LF version from package.json
Supamiu Feb 12, 2025
c1c7a87
feat(lint): Add scripts aliases for linters.
fbasmaison-lucca Feb 13, 2025
dd5af48
fix(stylelint): Rename `@lucca/stylelint-config` to `@lucca-front/…`.
fbasmaison-lucca Feb 17, 2025
8072d5e
fix(stylelint): Handle case where LF Version is unknown.
fbasmaison-lucca Feb 17, 2025
6cb719d
feat(lint): Use proper aliases for Jenkins.
fbasmaison-lucca Feb 17, 2025
e5011d8
fix(stylelint): Use properly formatted pattern for .button.mod-icon.
fbasmaison-lucca Feb 18, 2025
b02a267
fix(stylelint): Remove useledd `files` property in package.json.
fbasmaison-lucca Feb 18, 2025
4b937b1
doc(stylelint): Improve documentation:
fbasmaison-lucca Feb 18, 2025
4a3ced6
Merge branch 'rc' into stylelint
fbasmaison-lucca Feb 18, 2025
4d22748
fix(stylelint): Remove duplicated property.
fbasmaison-lucca Feb 18, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .storybook/public/mockServiceWorker.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
* - Please do NOT serve this file on production.
*/

const PACKAGE_VERSION = '2.6.8'
const PACKAGE_VERSION = '2.7.0'
const INTEGRITY_CHECKSUM = '00729d72e3b82faf54ca8b9621dbb96f'
const IS_MOCKED_RESPONSE = Symbol('isMockedResponse')
const activeClientIds = new Set()
Expand Down
3 changes: 0 additions & 3 deletions .stylelintrc

This file was deleted.

16 changes: 12 additions & 4 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,20 @@
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
"[scss]": {
"editor.formatOnSave": true,
"editor.defaultFormatter": "esbenp.prettier-vscode"
"editor.formatOnSave": true,
"editor.defaultFormatter": "stylelint.vscode-stylelint",
"editor.codeActionsOnSave": {
"source.fixAll.stylelint": "explicit"
},
},
"[markdown]": {
"editor.codeActionsOnSave": {
"source.fixAll.markdownlint": "explicit"
}
}
}
},
"stylelint.reportInvalidScopeDisables": true,
"stylelint.reportNeedlessDisables": true,
"stylelint.snippet": ["css", "scss"],
"stylelint.validate": ["css", "scss"],
"stylelint.customSyntax": "postcss-scss"
}
11 changes: 6 additions & 5 deletions CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,12 @@
Jenkinsfile @LuccaSA/ux-admins
.cd @LuccaSA/ux-admins

#
packages/ng @LuccaSA/ux-admins @LuccaSA/guilde-front
packages/ng/**/*.scss @LuccaSA/ux-devs
packages/icons @LuccaSA/ux-devs
packages/scss @LuccaSA/ux-devs
# Packages
packages/ng @LuccaSA/ux-admins @LuccaSA/guilde-front
packages/ng/**/*.scss @LuccaSA/ux-devs
packages/icons @LuccaSA/ux-devs
packages/scss @LuccaSA/ux-devs
packages/stylelint-config @LuccaSA/ux-devs @LuccaSA/guilde-front

# Storybook
stories @LuccaSA/ux-devs
5 changes: 3 additions & 2 deletions Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ node(label: CI.getSelectedLinuxNode(script:this)) {

npmScript(script: 'build')
npmScript(script: 'jenkins-test', skip: isPR)
npmScript(script: 'lint', skip: isPR)
npmScript(script: 'nglint', skip: isPR)
npmScript(script: 'stylelint', skip: isPR)

def shouldDeploy = isPR || isRc || isMaster || isRelease || isPreRelease
loggableStage('Deploy', !shouldDeploy) {
Expand All @@ -57,7 +58,7 @@ node(label: CI.getSelectedLinuxNode(script:this)) {
powershell "Remove-Item \\\\RBX1-SH1-TECH\\lucca-front\\${versionWithoutPrefix}\\storybook -Recurse"
powershell "Copy-Item storybook-static \\\\RBX1-SH1-TECH\\lucca-front\\${versionWithoutPrefix}\\storybook -Recurse"
}

unstash(name: "compodoc-static")
powershell "Remove-Item \\\\RBX1-SH1-TECH\\lucca-front\\${env.BRANCH_NAME}\\compodoc -Recurse"
powershell "Copy-Item compodoc-static \\\\RBX1-SH1-TECH\\lucca-front\\${env.BRANCH_NAME}\\compodoc -Recurse"
Expand Down
Loading