Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency phpunit/phpunit to v9 #465

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 6, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
phpunit/phpunit (source) ^8|^9 -> 8.5.38 age adoption passing confidence

Release Notes

sebastianbergmann/phpunit (phpunit/phpunit)

v8.5.38: PHPUnit 8.5.38

Compare Source

Changed
  • The namespaces of dependencies are now prefixed with PHPUnitPHAR instead of just PHPUnit for the PHAR distribution of PHPUnit

How to install or update PHPUnit

v8.5.37

Compare Source

v8.5.36

Compare Source

v8.5.35

Compare Source

v8.5.34

Compare Source

v8.5.33

Compare Source

v8.5.32

Compare Source

v8.5.31

Compare Source

v8.5.30

Compare Source

v8.5.29

Compare Source

v8.5.28

Compare Source

v8.5.27

Compare Source

v8.5.26

Compare Source

v8.5.25

Compare Source

v8.5.24

Compare Source

v8.5.23

Compare Source

v8.5.22

Compare Source

v8.5.21

Compare Source

v8.5.20

Compare Source

v8.5.19

Compare Source

v8.5.18

Compare Source

v8.5.17

Compare Source

v8.5.16

Compare Source

v8.5.15

Compare Source

v8.5.14

Compare Source

v8.5.13

Compare Source

v8.5.12

Compare Source

v8.5.11

Compare Source

v8.5.10

Compare Source

v8.5.9

Compare Source

v8.5.8

Compare Source

v8.5.7

Compare Source

v8.5.6

Compare Source

v8.5.5

Compare Source

v8.5.4

Compare Source

v8.5.3

Compare Source

v8.5.2

Compare Source

v8.5.1

Compare Source

v8.5.0

Compare Source

v8.4.3

Compare Source

v8.4.2

Compare Source

v8.4.1

Compare Source

v8.4.0

Compare Source

v8.3.5

Compare Source

v8.3.4

Compare Source

v8.3.3

Compare Source

v8.3.2

Compare Source

v8.3.1

Compare Source

v8.3.0

Compare Source

v8.2.5

Compare Source

v8.2.4

Compare Source

v8.2.3

Compare Source

v8.2.2

Compare Source

v8.2.1

Compare Source

v8.2.0

Compare Source

v8.1.6

Compare Source

v8.1.5

Compare Source

v8.1.4

Compare Source

v8.1.3

Compare Source

v8.1.2

Compare Source

v8.1.1

Compare Source

v8.1.0

Compare Source

v8.0.6

Compare Source

v8.0.5

Compare Source

v8.0.4

Compare Source

v8.0.3

Compare Source

v8.0.2

Compare Source

v8.0.1

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@github-actions github-actions bot temporarily deployed to pantheon-pr-465 March 6, 2024 07:09 Destroyed
@renovate renovate bot force-pushed the renovate/phpunit-phpunit-8.x branch from 1b9272a to 09ea79e Compare March 6, 2024 17:11
@github-actions github-actions bot temporarily deployed to pantheon-pr-465 March 6, 2024 17:14 Destroyed
@mrdavidburns
Copy link
Member

@justafish What do we do here when a compatible version breaks our builds?
I know we don't want to merge this because we don't want to pin to this specific version, but do we need to adjust things so that our builds all pass with the version that is being pinned here?

@mrdavidburns
Copy link
Member

Here's the conflict

  Problem 1
    - phpunit/phpunit 8.5.37 requires sebastian/diff ^3.0.2 -> found sebastian/diff[3.0.2, ..., 3.0.x-dev] but these were not loaded, likely because it conflicts with another require.
    - lullabot/drainpipe-dev dev-main requires phpunit/phpunit 8.5.37 -> satisfiable by phpunit/phpunit[8.5.37].
    - Root composer.json requires lullabot/drainpipe-dev @dev -> satisfiable by lullabot/drainpipe-dev[dev-main].

@mrdavidburns
Copy link
Member

Next step from meeting: When an issue like this, where the update is still within range of allowed versions then checkout the branch and try to fix the conflict so we know how to address the issue. Then we can discuss what we would need to merge in so others don't experience this error.

@renovate renovate bot force-pushed the renovate/phpunit-phpunit-8.x branch from 09ea79e to 692265e Compare April 5, 2024 06:08
@renovate renovate bot changed the title fix(deps): update dependency phpunit/phpunit to v8.5.37 fix(deps): update dependency phpunit/phpunit to v8.5.38 Apr 5, 2024
@github-actions github-actions bot temporarily deployed to pantheon-pr-465 April 5, 2024 06:11 Destroyed
@renovate renovate bot force-pushed the renovate/phpunit-phpunit-8.x branch from 692265e to 140bb7a Compare April 12, 2024 12:13
@justafish
Copy link
Member

@mrdavidburns It looks like phpunit 8 was dropped 9.x -> 10.x, so we can change this to ^9

@github-actions github-actions bot temporarily deployed to pantheon-pr-465 April 12, 2024 12:16 Destroyed
Copy link
Contributor Author

renovate bot commented Apr 12, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@github-actions github-actions bot temporarily deployed to pantheon-pr-465 April 12, 2024 12:21 Destroyed
@justafish justafish changed the title fix(deps): update dependency phpunit/phpunit to v8.5.38 fix(deps): update dependency phpunit/phpunit to v9 Apr 12, 2024
@justafish justafish merged commit c0097b4 into main Apr 12, 2024
36 checks passed
@justafish justafish deleted the renovate/phpunit-phpunit-8.x branch April 12, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants