Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up object logic #53

Closed
LunarWatcher opened this issue Dec 1, 2021 · 1 comment
Closed

Clean up object logic #53

LunarWatcher opened this issue Dec 1, 2021 · 1 comment
Labels
bug Something isn't working enhancement New feature or request v4.0.0

Comments

@LunarWatcher
Copy link
Owner

Jiangmiao's regex-based system is a mess, and certain parts of the logic just... aren't good, or are really flawed. Mixing regex with non-regex causes Fun Problems:tm: like #41, #52, and possibly more yet to be discovered bugs.

Replacing the rules with lexima-like rules should do the trick. The key takeaway from it is really that we separate regex from input and output, which should also simplify certain parts of the code. Admittedly, this is going to be completely breaking, so it'll have to be done for 4.0.0.

@LunarWatcher LunarWatcher added bug Something isn't working enhancement New feature or request v4.0.0 labels Dec 1, 2021
LunarWatcher added a commit that referenced this issue Nov 25, 2022
@LunarWatcher
Copy link
Owner Author

Very partial work has been performed here, but all the tests pass, and seems to behave much more sanely than the previous version.

I have some post-migration cleanup and documenting to do, but it's mostly far better now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request v4.0.0
Projects
None yet
Development

No branches or pull requests

1 participant