add html tag color #16
Conversation
|
To be completely honest, I'm not a fan of the colors, but looking at VSCode and Sublime Text, it seems the be the way it is done on there too. |
colors/ayu.vim
Outdated
| hi def htmlBold term=bold cterm=bold gui=bold | ||
| hi def htmlBoldUnderline term=bold,underline cterm=bold,underline gui=bold,underline | ||
| hi def htmlBoldItalic term=bold,italic cterm=bold,italic gui=bold,italic | ||
| hi def htmlBoldUnderlineItalic term=bold,italic,underline cterm=bold,italic,underline gui=bold,italic,underline | ||
| hi def htmlUnderline term=underline cterm=underline gui=underline | ||
| hi def htmlUnderlineItalic term=italic,underline cterm=italic,underline gui=italic,underline | ||
| hi def htmlItalic term=italic cterm=italic gui=italic |
There was a problem hiding this comment.
Are those needed?
From what I can see, they're already defined.
There was a problem hiding this comment.
where's it located? when I install ayu without any other plugins, it doesn't show anything as defined by those codes. hm, maybe this is a problem with my terminal? I will check it again
There was a problem hiding this comment.
I agree, it looks like it needs to be removed and it is already built-in
|
I've removed the unnecessary code and change the color for the text inside the < a > tag Before After |
What is the reasoning behind this change? It seems logical to me that the contents of a Link tag would be highlighted like a link, no? |
|
I think it will be confusing because it's the same color as the tag, I changed this because before I had a problem with this, other than that if I look at the Ayu theme vscode, all the text inside the tag is white. what do you think? does it need to be removed too? |
| call ayu#hi('htmlEndTag', 'tag', '') | ||
|
|
||
| " attribute | ||
| call ayu#hi('htmlArg', 'operator', '') |
There was a problem hiding this comment.
Change operator to accent to be even more consistent with VSCode & Sublime Text and we're good after that!
It's all good. Apply the small change and I'll merge this! |
it still doesn't support some html5 tags like < svg > and so on, so I still need to install https://github.com/othree/html5.vim