started javascript-II #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eep trying before i ask for help
ch-ance
approved these changes
Jan 23, 2019
| @@ -56,28 +56,96 @@ const runners = [{"id":1,"first_name":"Charmain","last_name":"Seiler","email":"c | |||
| // ==== Challenge 1: Use .forEach() ==== | |||
| // The event director needs both the first and last names of each runner for their running bibs. Combine both the first and last names into a new array called fullName. | |||
| let fullName = []; | |||
| console.log(fullName); | |||
| runners.forEach(function(obj) { | |||
| fullName.push([obj.first_name + obj.last_name]) | |||
There was a problem hiding this comment.
This is gonna look weird.. "LydiaThornton" vs "Lydia Thornton" for example
|
|
||
| // ==== Challenge 2: Use .map() ==== | ||
| // The event director needs to have all the runner's first names converted to uppercase because the director BECAME DRUNK WITH POWER. Convert each first name into all caps and log the result | ||
| let allCaps = []; | ||
| console.log(allCaps); | ||
| runners.map(function(obj) { |
There was a problem hiding this comment.
.map() returns an array, so you don't need to use "push()" here
|
|
||
| // ==== Challenge 2: Use .map() ==== | ||
| // The event director needs to have all the runner's first names converted to uppercase because the director BECAME DRUNK WITH POWER. Convert each first name into all caps and log the result | ||
| let allCaps = []; | ||
| console.log(allCaps); | ||
| runners.map(function(obj) { | ||
| allCaps.push(obj.first_name.toUpperCase()); |
There was a problem hiding this comment.
Suggested change
| allCaps.push(obj.first_name.toUpperCase()); | |
| allCaps = runners.map(obj => obj.first_name.toUpperCase()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
worked through most of array method.. having some issues with reduce, but want to keep trying.