Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a *get_sotdma_comm_state* method #68

Merged
merged 4 commits into from
May 15, 2022
Merged

Conversation

M0r13n
Copy link
Owner

@M0r13n M0r13n commented May 8, 2022

Related to #17

Copy link

@anttinousiainen anttinousiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe default values for SOTDMA-radio-fields should be something not valid for the actual message?

ie. UTC hours and minutes default to zero, which is a valid value for them, so it is not easy to see if it really UTC 00:00.

I see in real messages UTC reported as 24:60 when not available, but would -1 be a good default?

@anttinousiainen
Copy link

anttinousiainen commented May 8, 2022

Also:

  • parser/decoder should check whether radio_state is infact SOTDMA
  • optionally parser/decoder should handle ITDMA, FATDMA and RATDMA data fields where present as well. Quick glance on the spec (*) suggest maybe only ITDMA radio_status is present in the messages (in addition to SOTDMA)

(*) RECOMMENDATION ITU-R M.1371-1

@M0r13n
Copy link
Owner Author

M0r13n commented May 13, 2022

@anttinousiainen

Maybe default values for SOTDMA-radio-fields should be something not valid for the actual message?

Totally right. In Python it is common to just use None for none available fields. Therefore, I decided to just set all fields to None by default.

parser/decoder should check whether radio_state is infact SOTDMA
optionally parser/decoder should handle ITDMA, FATDMA and RATDMA data fields where present as well. Quick glance on the spec (*) suggest maybe only ITDMA radio_status is present in the messages (in addition to SOTDMA)

You are right. I added a method named get_itdma_comm_state(). I also added the required logic to distinguish between ITDMA and SOTDMA messages.

@M0r13n M0r13n force-pushed the interpret-radio-status-fields branch from 2c5cc15 to d0b7819 Compare May 14, 2022 12:13
@M0r13n M0r13n force-pushed the interpret-radio-status-fields branch from d0b7819 to fdb2ab4 Compare May 14, 2022 12:20
@M0r13n M0r13n merged commit a376ab4 into master May 15, 2022
@M0r13n M0r13n deleted the interpret-radio-status-fields branch March 4, 2023 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants