Store MMSI identifier as strings with leading zeros (#6) #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@M0r13n when do you think this will be available on PyPi? |
|
@aspcanada It is with version 1.3.0 (which is the most recent one). You should be able to upgrade via pip. |
|
I think you forgot to update |
|
Yes. You are totally right. I will fix it over the weekend. Thanks for the mention! |
|
Fixed the bug with Version |
jimbofreedman
pushed a commit
to Spot-Ship/pyais
that referenced
this pull request
Oct 15, 2024
Needs eta as string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated by @ajakz (#6 ), a MMSI identifier is a 9-digit number - which ALWAYS has 9 digits and therefore can not be stored as a native int.
I firstly thought about adding the option to enable/disable this feature in order to not break with the current API. But after a bit of research I decided make a break and store MMSI's as strings from now on. The reasons for that are:
123 != "00123")This means that you might need to update your code, if you want to use the lib from now on.