WIP: Feat/tck #33
Merged
WIP: Feat/tck #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptitFicus
force-pushed
the
feat/tck
branch
2 times, most recently
from
6c31f18
to
d5cc91c
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ptitFicus
commented
May 10, 2021
| @@ -17,7 +17,7 @@ jobs: | |||
| run: sbt publishLocal | |||
| - name: Run test | |||
| id: test | |||
| run: JAVA_OPTS="--enable-preview" sbt test | |||
| run: JAVA_OPTS="--enable-preview" sbt "project thoth-core" test && sbt "project thoth-jooq" test && sbt "project thoth-jooq-async" test && sbt "project thoth-kafka-goodies" test && sbt "project thoth-tck" test | |||
There was a problem hiding this comment.
Ease tests debug with github actions (otherwise logs are mixed up)
ptitFicus
commented
May 10, 2021
thoth-core/src/main/java/fr/maif/eventsourcing/impl/KafkaEventPublisher.java
Show resolved
Hide resolved
ptitFicus
commented
May 10, 2021
| stop.toCompletableFuture().join(); | ||
| assertThat(isStopping.get()).isTrue(); |
There was a problem hiding this comment.
Avoid race condition : once in a while, isStopping is not yet set to true right after "stop" call
ptitFicus
commented
May 10, 2021
| @@ -196,7 +196,7 @@ public void eventConsumptionWithEventFromDb() throws IOException { | |||
| assertThat(events).hasSize(6); | |||
|
|
|||
| verify(eventStore, times(1)).markAsPublished(any(), Mockito.<List<EventEnvelope<TestEvent, Void, Void>>>any()); | |||
| verify(eventStore, times(1)).markAsPublished(Mockito.<List<EventEnvelope<TestEvent, Void, Void>>>any()); | |||
| verify(eventStore, atLeastOnce()).markAsPublished(Mockito.<List<EventEnvelope<TestEvent, Void, Void>>>any()); | |||
There was a problem hiding this comment.
There seems to be a race condition here as well, perhaps in some cases akka loads events from DB in two batchs ?
ptitFicus
force-pushed
the
feat/tck
branch
2 times, most recently
from
de1f5f0
to
cf34d70
Compare
Open
larousso
approved these changes
May 21, 2021
thoth-core/src/main/java/fr/maif/eventsourcing/impl/KafkaEventPublisher.java
Show resolved
Hide resolved
| try { | ||
| return eventStore.loadAllEvents().runWith(Sink.seq(), actorSystem).toCompletableFuture().get(); | ||
| } catch (InterruptedException e) { | ||
| throw new RuntimeException(e); |
There was a problem hiding this comment.
You can group it catch (InterruptedException | ExecutionException e)
| for(EventEnvelope<TestEvent, Tuple0, Tuple0> env: envelopes) { | ||
| if(result.stream().noneMatch(env2 -> env2.id.equals(env.id))) { | ||
| result.add(env); | ||
| } |
There was a problem hiding this comment.
return envelopes.distinctBy(env -> env.id);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.