Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Octopi.txt fix #1

Merged
merged 3 commits into from
May 29, 2023
Merged

Octopi.txt fix #1

merged 3 commits into from
May 29, 2023

Conversation

Gunvor4
Copy link
Contributor

@Gunvor4 Gunvor4 commented May 25, 2023

Downloaded new version of octopi.txt, and modified REPLACEMENT_STRINGS to match the new file.

@Gunvor4 Gunvor4 requested a review from ddabble May 25, 2023 21:53
ddabble
ddabble requested changes May 25, 2023
View reviewed changes
Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this should make the script more future-proof 👌

I have a couple change requests, however: 🙂

python_scripts/customize_octopi_config.py Outdated Show resolved Hide resolved
python_scripts/customize_octopi_config.py Outdated Show resolved Hide resolved
@Gunvor4
Updated customize_octopi_config.py
68e2aaf 
Updated customize_octopi_config.py so that the script now download the updated version of the file octopi.txt, makes the necessary replacements in the file, compares it to the old file, and saves the new file if the two versions do not match
ddabble
ddabble approved these changes May 27, 2023
View reviewed changes
Copy link
Member

@ddabble ddabble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

I added some comments, as well as updated the printing of which lines were written to the file :) I haven't tested the changes on an RPi yet, though 😅

@ddabble
Copy link
Member

ddabble commented May 27, 2023 •
edited
Loading

Alright nvm, tested it now on MAKE-009, and it works like a charm 😄

@Gunvor4 Gunvor4 merged commit 2188a7a into main May 29, 2023
@Gunvor4 Gunvor4 deleted the octopi.txt_fix branch May 29, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddabble ddabble ddabble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gunvor4 @ddabble