Hotfix deployment #437
Merged
Hotfix deployment #437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both because it's fairly hard to remember that they're there, which also makes it harder to maintain (like updating the `__all__` list of files), and because doing things like this is mainly appropriate when creating a library. This also fixes an issue where the settings were being referenced (through importing `make_queue.views.stream.stream.StreamConsumer` in `asgi.py`) before the environment variable had been set (in `asgi.py`), when running the `runworker` management command.
`django-simple-history` doesn't currently track changes to many-to-many relationships - which was the main point of this commit (i.e. to track the changes to `own_permissions`) - but once jazzband/django-simple-history#399 is resolved (likely through jazzband/django-simple-history#932), it will.
The datetime format of the `Expires` field has also changed to ISO 8601.
The filenames in the contents of the MathJax files were not changed to their hashed versions when running the `collectstatic` management command (as should normally happen; see https://docs.djangoproject.com/en/4.0/ref/contrib/staticfiles/#manifeststaticfilesstorage), which caused some JavaScript errors when the library tried to request its other files. This could have been solved by replacing the names of files in the contents of the MathJax files, with their hashed versions, but the way a lot of these filenames were being referenced to, made it hard to create patterns (like the ones in `ManifestStaticFilesStorage.patterns`) for replacing these. Placed all the MathJax files inside a folder with the version number as its name; see the comments of the `MANIFEST_STATICFILES_IGNORE_PATTERNS` setting for reasoning. Also moved the URL parameter for `MathJax.js` outside of the `static` template tag (in `mathjax_render.html`), as it's not part of the filename.
Hotfixes after deployment
ddabble
added
the
deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in the changes from #436.