Deployment #567
Merged
Deployment #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [phonenumbers](https://github.com/daviddrysdale/python-phonenumbers) from 8.12.51 to 8.12.52. - [Release notes](https://github.com/daviddrysdale/python-phonenumbers/releases) - [Commits](daviddrysdale/python-phonenumbers@v8.12.51...v8.12.52) --- updated-dependencies: - dependency-name: phonenumbers dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
...after 0a6fdd0, in which the `site` context variable was replaced with `get_absolute_uri_for_path` in `ticket.html` and `ticket.txt`.
...after replacing the `site` context variable with `get_absolute_uri_for_path` in `ticket.html` and `ticket.txt` (in 0a6fdd0).
...and replaced some uses of `format_html()` with the new tag.
Among other things, added the ticket's preferred language and comment to `ticket.html` and `ticket.txt`, and added the ticket UUID to `ticket.txt`.
This makes it possible to see the emails that are sent, as sending emails the standard way will normally fail when developing locally.
Fix sending emails
This made `MultiLingualTextStructure`s always equal each other, which caused `django-simple-history` to delete previous versions of objects (where only `MultiLingualTextStructure`-based fields were changed, like `ContentBox.content`) when running the `clean_duplicate_history` command.
...which are - among other places - used in the "Add New Member" form. The standard widget attributes (through the `attrs.html` template) should generally always be placed on the "real" `<input>` tag holding the value that will be submitted for the form field, and not the (usually dynamically created) `.search` input tag. What seems to be a downside of this bugfix, is that the "Please fill out this field." error message (preventing the form from being submitted) is no longer shown when trying to submit a form with a required field using this widget. Instead, an error message is shown after submitting the form and the page is reloaded. However, giving the `.search` input tag a `required` attribute (which is what enables the "Please fill out this field." error message) does not seem to be the intended usage anyway, as it's not mentioned anywhere in the docs (https://fomantic-ui.com/modules/dropdown.html), and it causes this bug.
Disregarded the line length for the checkboxes under the "Checklist" section, as the previously wrapped lines were also being displayed as wrapped on GitHub, which seems to be a bug with GitHub.
This makes the headers stick slightly more out, to make them easier to spot among all the other text.
...as this will use the newest minor/patch version of the major version.
Some hotfixes + small Markdown reformat
This will be used to automatically add PRs and issues from this repo (https://github.com/MAKENTNU/web) to the repo's Project (Kanban board) https://github.com/orgs/MAKENTNU/projects/1.
Also had to pass the `-r` flag to the existing `jq` calls, as the environment variables set in the "Get project data" step contained quotation marks, which were apparently parsed literally when using them as arguments in the `jq` calls in the "Get project item data" step. This was immensly useful for figuring out the API: https://docs.github.com/en/graphql/overview/explorer ...combined with the following part of the docs, even though it didn't describe finding info about *specific* items: https://docs.github.com/en/issues/planning-and-tracking-with-projects/automating-your-project/using-the-api-to-manage-projects#finding-information-about-items-in-a-project
This will be customized for equivalent use with issues, in an upcoming commit.
...instead of pull requests.
GitHub project workflows
ddabble
added
the
deployment
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| {% translate "If you want to cancel your registration, you can do so by going to" %} | ||
| <a href="{% get_absolute_uri_for_path request cancel_url %}">{% translate "this page" %}</a>. | ||
| {% translate "If you want to cancel your registration, you can do so by visiting the following page" %}: | ||
| <a href="{% get_absolute_uri_for_path request cancel_url %}" target="_blank"> |
Check warning
Code scanning / CodeQL
Potentially unsafe external link
| <img src="{{ site }}{{ ticket.registered_event.image.url }}" | ||
| style="width: 100%;" alt="{{ ticket.registered_event.image_description }}" | ||
| /> | ||
| <a href="{{ event_url }}" target="_blank"> |
Check warning
Code scanning / CodeQL
Potentially unsafe external link
| style="width: 500px; max-width: 100%;" alt="{% translate "MAKE NTNU's logo" %}" | ||
| /> | ||
| {% url 'front_page' as front_page_url %} | ||
| <a href="{% get_absolute_uri_for_path request front_page_url %}" target="_blank"> |
Check warning
Code scanning / CodeQL
Potentially unsafe external link
Codecov Report
@@ Coverage Diff @@
## main #567 +/- ##
==========================================
- Coverage 88.50% 88.46% -0.04%
==========================================
Files 132 132
Lines 5507 5514 +7
==========================================
+ Hits 4874 4878 +4
- Misses 633 636 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Merging without approval, for the same reasons mentioned in the last comment in each of the listed PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in the changes from the following PRs:
Also the following automated PRs: