-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tedpca CLI fix #950
tedpca CLI fix #950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. check_tedpca_value
should be able to validate the value.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
=======================================
Coverage 88.97% 88.97%
=======================================
Files 27 27
Lines 3373 3373
Branches 617 617
=======================================
Hits 3001 3001
Misses 226 226
Partials 146 146
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks, Dan and the team, Yes, that is what I did on my venv as well. Thanks for fixing this issue quickly. |
Closes #949.
Changes proposed in this pull request:
tedpca
can accept several strings or numbers as inputs, but the argument parser for the command line interface (CLI) rejected any option exceptaic
mdl
orkic
.@BahmanTahayori Can you check to confirm this resolves your issue?