Skip to content

Add public interface for k_div_T #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

Add public interface for k_div_T #524

merged 1 commit into from
Apr 24, 2023

Conversation

rjfarmer
Copy link
Collaborator

I've had a request to make the binary_tides.f90 function k_div_T made publically available. Comments on the API?

@rjfarmer rjfarmer requested a review from orlox as a code owner April 18, 2023 11:03
@fxt44
Copy link
Member

fxt44 commented Apr 18, 2023

real(dp) function binary_compute_k_div_T(binary_id, is_donor, has_convective_envelope, ierr)

would returning "k" or T" be useful auxiliary info?

@rjfarmer
Copy link
Collaborator Author

real(dp) function binary_compute_k_div_T(binary_id, is_donor, has_convective_envelope, ierr)

would returning "k" or T" be useful auxiliary info?

I don't think so. It's the kind of quantity that's just used as (k/T) and not k or T

@rjfarmer rjfarmer merged commit 54c4dc0 into main Apr 24, 2023
@rjfarmer rjfarmer deleted the rf/kdivt branch April 24, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlox orlox Awaiting requested review from orlox orlox is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjfarmer @fxt44