Skip to content

Conversation

sbryngelson
Copy link
Member

@sbryngelson sbryngelson commented Jul 19, 2025

User description

Reverts #955


PR Type

Other


Description

  • Revert cursor rules file formatting changes

  • Restore original YAML header format

  • Remove extensive documentation sections

  • Simplify GPU programming guidelines


Diagram Walkthrough

flowchart LR
  A["Original Rules"] --> B["Reverted Changes"]
  B --> C["Simplified Content"]
  B --> D["Fixed YAML Header"]
Loading

File Walkthrough

Relevant files
Miscellaneous
mfc-agent-rules.mdc
Revert cursor rules file changes                                                 

.cursor/rules/mfc-agent-rules.mdc

  • Revert YAML header from triple dashes to triple hyphens
  • Remove extensive documentation sections (4-10)
  • Restore original line formatting and spacing
  • Simplify GPU programming guidelines section
+28/-122

@Copilot Copilot AI review requested due to automatic review settings July 19, 2025 18:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts changes made to the Cursor IDE agent rules configuration file for the MFC (many-physics solver) project. The revert undoes modifications that were made to improve formatting and add additional sections to the agent rules.

  • Reverts formatting changes that split long lines and reorganized content
  • Removes extensive additional documentation sections that were added about file structure, GPU acceleration, memory management, and Fortran best practices
  • Returns to a more concise version of the agent rules

---

# 3 FYPP Macros for GPU acceleration Pogramming Guidelines (for GPU kernels)
# 3 FYPP Macros for GPU acceleration Pogramming Guidelines (for kernels)
Copy link
Preview

Copilot AI Jul 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in 'Pogramming' which should be 'Programming'.

Suggested change
# 3 FYPP Macros for GPU acceleration Pogramming Guidelines (for kernels)
# 3 FYPP Macros for GPU acceleration Programming Guidelines (for kernels)

Copilot uses AI. Check for mistakes.

Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Content Loss

The revert removes extensive documentation sections (4-10) that contained valuable guidance on file structure, Fypp macros, documentation style, error handling, memory management, and Fortran best practices. This could impact developer productivity and code consistency.

$:GPU_PARALLEL_FOR(private='[...]', copy='[...]')
  • Add collapse=n to merge nested loops when safe.
  • Declare loop-local variables with private='[...]'.
  • Allocate large arrays with managed or move them into a persistent
    $:GPU_ENTER_DATA(...) region at start-up.
  • Do not place stop / error stop inside device code.
  • Must compile with Cray ftn and NVIDIA nvfortran for GPU offloading; also build CPU-only with
    GNU gfortran and Intel ifx/ifort.

</details>

<details><summary><a href='https://github.com/MFlowCode/MFC/pull/957/files#diff-dfc3b3fa988ba58b3897926dc4334a9684383514b68556f28db8671337817b1aR69-R69'><strong>Formatting Issue</strong></a>

Line 69 contains a typo "Pogramming" instead of "Programming" in the section header, which affects readability and professionalism of the documentation.
</summary>

```txt
# 3  FYPP Macros for GPU acceleration Pogramming Guidelines (for kernels)

Copy link

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Fix typo in section header

Fix the typo in "Pogramming" which should be "Programming". This typo affects
the readability and professionalism of the documentation header.

.cursor/rules/mfc-agent-rules.mdc [69]

-# 3  FYPP Macros for GPU acceleration Pogramming Guidelines (for kernels)
+# 3  FYPP Macros for GPU acceleration Programming Guidelines (for kernels)
Suggestion importance[1-10]: 3

__

Why: The suggestion correctly identifies a typo ("Pogramming") in a markdown header and provides a valid fix, which improves the document's quality.

Low
  • More

@sbryngelson sbryngelson deleted the revert-955-cursor-rules branch July 22, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant