-
Notifications
You must be signed in to change notification settings - Fork 117
Some LAPACK fixups #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some LAPACK fixups #974
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR focuses on LAPACK-related improvements and documentation reorganization. The changes add LAPACK library dependencies to build systems and consolidate GPU-related documentation.
Key changes:
- Adds LAPACK package installation to CI workflows and documentation
- Consolidates GPU debugging documentation into the main GPU parallelization file
- Updates documentation navigation structure with cleaner naming
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
docs/documentation/readme.md | Simplifies navigation link names by removing "MFC" prefix |
docs/documentation/papers.md | Adds new MFC 5.0 paper citation and BibTeX entry |
docs/documentation/gpuParallelization.md | Incorporates GPU debugging content from separate file |
docs/documentation/gpuDebugging.md | File deleted - content moved to gpuParallelization.md |
docs/documentation/getting-started.md | Adds LAPACK dependencies to Ubuntu and macOS installation instructions |
README.md | Adds LAPACK to macOS installation command and updates test count description |
.github/workflows/test.yml | Adds LAPACK packages to both Ubuntu and macOS CI environments |
.github/workflows/coverage.yml | Adds LAPACK packages to Ubuntu CI environment |
.github/workflows/cleanliness.yml | Adds LAPACK packages to Ubuntu CI environment |
sudo apt update -y | ||
sudo apt install -y tar wget make cmake gcc g++ python3 python3-dev "openmpi-*" libopenmpi-dev | ||
sudo apt install -y tar wget make cmake gcc g++ python3 python3-dev "openmpi-*" libopenmpi-dev libblas-dev liblapack-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are trailing spaces at the end of this line that should be removed.
sudo apt install -y tar wget make cmake gcc g++ python3 python3-dev "openmpi-*" libopenmpi-dev libblas-dev liblapack-dev | |
sudo apt install -y tar wget make cmake gcc g++ python3 python3-dev "openmpi-*" libopenmpi-dev libblas-dev liblapack-dev |
Copilot uses AI. Check for mistakes.
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
Lapack fixups. Adds some package installs to runners, fixes up some docs.
PR Type
Enhancement, Documentation
Description
Add LAPACK dependencies to CI workflows and documentation
Consolidate GPU debugging documentation into main file
Update README and documentation formatting
Fix minor typos and improve documentation structure
Diagram Walkthrough
File Walkthrough
3 files
Add LAPACK dependencies to Ubuntu setup
Add LAPACK dependencies to Ubuntu setup
Add LAPACK to MacOS and Ubuntu setups
6 files
Update dependencies and test count description
Add LAPACK deps and fix formatting
Remove standalone GPU debugging file
Consolidate GPU debugging content into main file
Add new MFC 5.0 paper citation
Update documentation index structure and titles