Skip to content

Conversation

sbryngelson
Copy link
Member

@sbryngelson sbryngelson commented Aug 14, 2025

User description

fix lint


PR Type

Other


Description

  • Add new linter ignore rules to configuration

File Walkthrough

Relevant files
Configuration changes
.fortitude.toml
Update linter ignore rules                                                             

.fortitude.toml

  • Added C061 and OB011 to the ignore list in the check configuration
+1/-1     

@Copilot Copilot AI review requested due to automatic review settings August 14, 2025 21:25
Copy link

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Overbroad Ignores

Newly added ignore codes like C061 and OB011 may mask real issues; confirm they are necessary and scoped appropriately to avoid degrading code quality.

ignore = ["E001","S001","S101","C121","S091","MOD011","C001","S101","S102","C002","PORT011","C061","C072","C003","C131","C141","C092","OB011"]
file-extensions = ["f90","fpp","fypp"]

Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds two new Fortitude linter rule exclusions (C061 and OB011) to the ignore list in the configuration file. This appears to be a maintenance change to suppress additional linting warnings that were likely introduced by recent code changes or linter updates.

Key changes:

  • Updated .fortitude.toml to ignore two additional linter rules

@@ -1,4 +1,4 @@
[check]
ignore = ["E001","S001","S101","C121","S091","MOD011","C001","S101","S102","C002","PORT011","C072","C003","C131","C141","C092"]
ignore = ["E001","S001","S101","C121","S091","MOD011","C001","S101","S102","C002","PORT011","C061","C072","C003","C131","C141","C092","OB011"]
Copy link
Preview

Copilot AI Aug 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule "S101" appears twice in the ignore list (positions 3 and 8). This duplication should be removed to keep the configuration clean and avoid confusion.

Suggested change
ignore = ["E001","S001","S101","C121","S091","MOD011","C001","S101","S102","C002","PORT011","C061","C072","C003","C131","C141","C092","OB011"]
ignore = ["E001","S001","S101","C121","S091","MOD011","C001","S102","C002","PORT011","C061","C072","C003","C131","C141","C092","OB011"]

Copilot uses AI. Check for mistakes.

@sbryngelson sbryngelson merged commit e13bf90 into MFlowCode:master Aug 14, 2025
18 checks passed
@sbryngelson sbryngelson deleted the fix-lint branch September 2, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant