Skip to content

Conversation

prathi-wind
Copy link
Collaborator

@prathi-wind prathi-wind commented Sep 15, 2025

Description

All test cases pass with OpenMP on Nvidia hardware.

IPO is causing 1D chemistry cases to fail, so I turned it off when compiling for OpenMP.

Fixes #(issue) [optional]

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

If you cannot check the above box, please split your PR into multiple PRs that each have a common goal.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.
Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • What computers and compilers did you use to test this:

Checklist

  • I have added comments for the new code
  • I added Doxygen docstrings to the new code
  • I have made corresponding changes to the documentation (docs/)
  • I have added regression tests to the test suite so that people can verify in the future that the feature is behaving as expected
  • I have added example cases in examples/ that demonstrate my new feature performing as expected.
    They run to completion and demonstrate "interesting physics"
  • I ran ./mfc.sh format before committing my code
  • New and existing tests pass locally with my changes, including with GPU capability enabled (both NVIDIA hardware with NVHPC compilers and AMD hardware with CRAY compilers) and disabled
  • This PR does not introduce any repeated code (it follows the DRY principle)
  • I cannot think of a way to condense this code and reduce any introduced additional line count

If your code changes any code source files (anything in src/simulation)

To make sure the code is performing as expected on GPU devices, I have:

  • Checked that the code compiles using NVHPC compilers
  • Checked that the code compiles using CRAY compilers
  • Ran the code on either V100, A100, or H100 GPUs and ensured the new feature performed as expected (the GPU results match the CPU results)
  • Ran the code on MI200+ GPUs and ensure the new features performed as expected (the GPU results match the CPU results)
  • Enclosed the new feature via nvtx ranges so that they can be identified in profiles
  • Ran a Nsight Systems profile using ./mfc.sh run XXXX --gpu -t simulation --nsys, and have attached the output file (.nsys-rep) and plain text results to this PR
  • Ran a Rocprof Systems profile using ./mfc.sh run XXXX --gpu -t simulation --rsys --hip-trace, and have attached the output file and plain text results to this PR.
  • Ran my code using various numbers of different GPUs (1, 2, and 8, for example) in parallel and made sure that the results scale similarly to what happens if you run without the new code/feature

prathi-wind and others added 30 commits July 22, 2025 13:16
…, started work on enter and exit data, compiles
…e, add mappers to derived types, change how allocate is done
…types, removed rest of pure functions, fix issue with acoustic on nvfortran
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

❌ Patch coverage is 30.23256% with 330 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.83%. Comparing base (c86fdd9) to head (cc25407).

Files with missing lines Patch % Lines
src/simulation/m_cbc.fpp 7.31% 35 Missing and 3 partials ⚠️
src/simulation/m_hypoelastic.fpp 17.14% 27 Missing and 2 partials ⚠️
src/simulation/m_derived_variables.fpp 10.00% 26 Missing and 1 partial ⚠️
src/simulation/m_rhs.fpp 10.34% 26 Missing ⚠️
src/simulation/m_bubbles_EL.fpp 40.00% 23 Missing and 1 partial ⚠️
src/simulation/m_time_steppers.fpp 17.24% 24 Missing ⚠️
src/common/m_boundary_common.fpp 42.42% 19 Missing ⚠️
src/common/m_mpi_common.fpp 5.00% 19 Missing ⚠️
src/simulation/m_acoustic_src.fpp 21.05% 15 Missing ⚠️
src/simulation/m_hyperelastic.fpp 0.00% 15 Missing ⚠️
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #999      +/-   ##
==========================================
+ Coverage   41.75%   45.83%   +4.08%     
==========================================
  Files          70       66       -4     
  Lines       20126    13485    -6641     
  Branches     2504     1574     -930     
==========================================
- Hits         8403     6181    -2222     
+ Misses      10180     6428    -3752     
+ Partials     1543      876     -667     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@prathi-wind prathi-wind changed the title Openmp nvidia merged master Add OpenMP support for Nvidia hardware Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants